270 feature add description field to forminstance and formtemplate #292
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
apps/server/src/form-instances/entities/form-instance.entity.ts
Outdated
Show resolved
Hide resolved
| @@ -112,6 +112,7 @@ const CreateFormInstanceModal: React.FC<CreateFormInstanceModalProps> = ({ | |||
| originatorId: user?.id!, | |||
| formTemplateId: selectedFormTemplate?.id!, | |||
| formDocLink: selectedFormTemplate?.formDocLink!, | |||
| description: selectedFormTemplate?.description!, | |||
There was a problem hiding this comment.
instead of a non-null assertion, can we add some sort of handling instead? this will cause an error if there's no description provided. the description should be optional i believe, maybe it won't require the assertion if you change the dto to have the field be optional.
There was a problem hiding this comment.
I just changed it to use null instead if not defined. Not sure we use this component anymore though, so Bryan will have to check this for the new form instance flow
| @@ -0,0 +1,11 @@ | |||
| Error requesting http://localhost:8080/api-json | |||
There was a problem hiding this comment.
we should remove this file?
There was a problem hiding this comment.
and the other ones too
There was a problem hiding this comment.
Yeah definitely, missed that those got generated!
This reverts commit fceb8cf.
…into 270-feature-add-description-field-to-forminstance-and-formtemplate
Description
Add description fields to form instance and form template as a string. Descriptions are added when form instances and templates are created. Switched assign-group-entity to use ApiProperty instead of ApiPropertyOptional for consistency.
Also deleted form template modal because we do not use it anymore.
Motivation and Context
Allows the descriptions we have the user input during the create template process to persist / be saved when the template is created.
Closes [#270 ]
How has this been tested?
Tested to confirm a form template could be made with a description. Will need to test further to ensure it works with the frontend of the new form instance flow once both are merged.
Screenshots (if appropriate):
Types of changes
Checklist: