Skip to content

Conversation

@ocdtrekkie
Copy link
Collaborator

Fixes #258 and #356

So this was initially written by Perplexity AI (because I thought this would be a good test case for upgrading existing code in an easily-parsable and testable way), but I stripped some changes back (it messed with a variable name), and it handled init differently which seemed silly, so I made it handle init the same way it handles setupvm and upgradevm. It also included the exact file being checked in the prompt, and I changed the language there because I am testing for the existence of one file, but using it to prompt for confirmation of the entire action. (I believe the return should end the entire function?)

Note that I have not yet tested this at all, but will do some tests on it later today and verify if it works as intended. It reads reasonable to me though.

I'd be thrilled if anyone else was able to test this too. cc: @neuroradiology @orblivion @troyjfarrell

@ocdtrekkie
Copy link
Collaborator Author

Force-push was because the noninteractive variable was only set within the setup_vm function, and without even running it that seems obviously also wrong. :D

@ocdtrekkie
Copy link
Collaborator Author

This is now tested on all three code paths for all three commands, so I'm pretty confident in it. (I will probably merge within the next few hours because Hacktoberfest is ending and I like having padding on my completion, but review is still quite welcome.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants