Y26-050 performance improvements for the gbs pipeline - Fix #2#2846
Draft
KatyTaylor wants to merge 5 commits into
Draft
Y26-050 performance improvements for the gbs pipeline - Fix #2#2846KatyTaylor wants to merge 5 commits into
KatyTaylor wants to merge 5 commits into
Conversation
[release] Merge Develop into Master for 3.96.7
[release] Merge Develop into Master for 3.96.8
[release] Merge Develop into Master for 3.97.0
…rch controller create method was redirecting to the labware, causing lots of unnecessary API calls. This brings the subset of those calls that are necessary into the search controller and takes out the redirect. The UI action is now virtually instantaneous (compared to 16 seconds in local).
…nd js console error, because data[this.dataset.labwareType] was undefined (response contained a 'tube' key rather than a 'plate' key.
KatyTaylor
changed the title
Member
|
@KatyTaylor In code review but failing tests and lint, want to fix first? |
Collaborator
Author
Yes sorry, on my to do list. Marked as 'draft'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version