X1536 freeze thaw by yoldas · Pull Request #1203 · sanger/stan-client

yoldas · 2026-06-15T20:53:23Z

Changes proposed in this pull request

freeze/thaw

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
- Check story numbers included
- Check for debug code
- Check version

…rozen boolean; redundant if LabwareState.Frozen is always reflected in state)

yoldas · 2026-06-17T15:10:35Z

rebased x1536-freeze-thaw branch to remove experimental Edit treatment types changes. Saved those commits to edit-treatment-types branch.

… spec compatibility

…ubmission

… and thaw

…maging

…outes

…loader is empty

…lised frozen check

…en prop in RecordInPlace

…he mock service worker is registered from src/index.tsx before React renders

… and regenerate sdk.ts

…d mocks

…rozen is false

…Machine spec

yoldas · 2026-07-06T11:42:41Z

test failure hotspots to check for xeniumAnalyser

Issue: onAdd looks called twice in LabwareScanner for some reason.
Issue: check use of composeLabwareCheck in frozen true and false cases
Issue: figure out why cy.findByText('No probe hybridisation recorded for STAN-3111') not working.
Issue: check msw; clearly mocking is not working.
Issue: leak between tests; a mock set earlier looks used in a later test (FindLatestOperation)
Issue: SGP number / uploaded file is leaking to other test as well.

sabrine33 · 2026-07-06T12:09:18Z

test failure hotspots to check for xeniumAnalyser

Issue: onAdd looks called twice in LabwareScanner for some reason. Issue: check use of composeLabwareCheck in frozen true and false cases Issue: figure out why cy.findByText('No probe hybridisation recorded for STAN-3111') not working. Issue: check msw; clearly mocking is not working. Issue: leak between tests; a mock set earlier looks used in a later test (FindLatestOperation) Issue: SGP number / uploaded file is leaking to other test as well.

would like me to have a look into those with you ? I wonder why the msw is not working in your case ?

sabrine33 · 2026-07-07T14:03:55Z

thanks @yoldas, this is quite piece of work.
Just a couple of notes:

default the scanner to stop frozen labware ( I thought we already agreed on this)
per convention, it is recommended to have one component/page per URL ( it is not big dealer really)
I tested personally - when moving from one operation to another (thraw, cryopreserve) , it does not clear out the scanned labware

sabrine33 · 2026-07-07T09:08:15Z

+
+      previousLabwareLengthRef.current = currentLabwareLength;
+      prevCleanedOutAddressesLengthRef.current = curCleanedOutAddressesLength;
    });


can you explain what is the purpose of those changes, please

I used useRefs instead of consts. Instead of capturing from render, used the last seen value persisted across emissions and re-subscriptions and removed those refs from deps. I will check this again - one of the things I suspected during debugging: onAdd firing twice.

…loaded file case (review feeadback)

…aults to true

…ryopreserve

yoldas · 2026-07-08T10:41:18Z

I tested personally - when moving from one operation to another (thraw, cryopreserve) , it does not clear out the scanned labware

Thanks. I have added key attribute to reset RecordInPlace for thaw and cryopreserve transitions.

yoldas · 2026-07-08T10:49:59Z

per convention, it is recommended to have one component/page per URL ( it is not big dealer really)

Thanks. Yes, in this case the behaviour is the same aside from the operation type.
Story: "API: Use recordInPlace(request: InPlaceOpRequest!) with "Cryopreserve" or "Thaw" as the operation type."

…in LabwareScanner; instead of refs

…eeze-thaw # Conflicts: # src/components/labwareScanner/LabwareScanner.tsx # src/lib/machines/labware/labwareMachine.ts

yoldas mentioned this pull request Jun 17, 2026

x1536 client—As ARA (Holly) I want to record when I cryopreserve and when I thaw labware #1202

Open

yoldas added 4 commits June 17, 2026 16:03

feat(freeze-thaw): add cryopreserve and thaw routes

ed4df74

feat(freeze-thaw): add freeze/thaw navigation links in app shell

ba82433

feat(freeze-thaw): regenerate graphql types with frozen field support

88f9fee

feat(freeze-thaw): mark frozen labware as unusable in helper (using f…

6b6aaab

…rozen boolean; redundant if LabwareState.Frozen is always reflected in state)

yoldas force-pushed the x1536-freeze-thaw branch from 1fffcc1 to 6b6aaab Compare June 17, 2026 15:06

yoldas added 10 commits June 24, 2026 22:36

fix(freeze-thaw): keep isLabwareUsable state-based to restore history…

0a451c7

… spec compatibility

fix(history): wrap table cells in tr elements for valid tbody nesting

e74b9c9

test(history): fix navigate mock to return function and await async s…

4b0f72f

…ubmission

feat(freeze-thaw): add imaging qc completion toggle

fce575a

feat(freeze-thaw): hide imaging qc completion action for cryopreserve…

f4f26cf

… and thaw

test(freeze-thaw): add test for imaging qc toggle in record in place

6f90ef5

test(freeze-thaw): add thaw imaging qc toggle test

458bd73

feat(freeze-thaw): block frozen labware for non-thaw operations

3b04372

test(freeze-thaw): cover frozen labware thaw exception

9185913

fix(freeze-thaw): keep thaw completion without imaging qc option

b99e1ea

yoldas marked this pull request as ready for review June 25, 2026 01:54

yoldas requested review from khelwood and sabrine33 June 25, 2026 01:54

yoldas added 10 commits June 25, 2026 11:49

fix(freeze-thaw): default RecordInPlace Imaging QC option to false

8668baa

fix(freeze-thaw): enable Imaging QC next action explicitly for /lab/i…

7bff9e1

…maging

fix(freeze-thaw): remove equipment loader for cryopreserve and thaw r…

1f8c9fe

…outes

test(freeze-thaw): assert RecordInPlace hides equipment section when …

171b7c1

…loader is empty

feat(freeze-thaw): add rejectFrozen prop to LabwareScanner for centra…

6db1155

…lised frozen check

refactor(freeze-thaw): replace manual frozen callback with rejectFroz…

0e5a004

…en prop in RecordInPlace

feat(freeze-thaw): block frozen labware on operation pages

0a9f037

test(freeze-thaw): add test for frozen labware rejection in scanner

2732cf5

refactor(freeze-thaw): make allowed frozen-labware pages explicit

a9108ec

feat(freeze-thaw): block frozen labware in shared scanner flows

56b64a6

yoldas added 8 commits June 25, 2026 15:18

test(freeze-thaw): add test for CleanOut explicit allow-frozen wiring

5cf0b09

chore(ci): match cypress image to nvmrc

a7c2e8f

fix(ci): Enable REACT_APP_MOCK_API=msw on the Cypress build step so t…

f008f79

…he mock service worker is registered from src/index.tsx before React renders

feat(freeze-thaw): add frozen on Labware and LabwareFlagged fragments…

89b5dc3

… and regenerate sdk.ts

fix(ci): pass REACT_APP_MOCK_API via env block for cypress action

e00fc9b

fix(freeze-thaw): default frozen=false in labware factory, helper, an…

982dc06

…d mocks

fix(freeze-thaw): preserve labwareCheckFunction identity when rejectF…

6a5a615

…rozen is false

test(freeze-thaw): add frozen field to inline Labware mock in labware…

1950de8

…Machine spec

sabrine33 reviewed Jun 30, 2026

View reviewed changes

Comment thread src/components/labwareScanner/LabwareScanner.tsx Outdated

Comment thread src/components/labwareScanner/LabwareScanner.tsx Outdated

Comment thread src/lib/factories/labwareFactory.ts

Comment thread src/pages/OrientationQC.tsx Outdated

Merge branch 'devel' into x1536-freeze-thaw

3032dc3

yoldas added 4 commits July 6, 2026 14:03

fix duplicate onAdd call and xenium cypress tests

d5279f2

fix xenium analyzer test msw worker

e2151a4

refactor(freeze-thaw): add labware util to check frozen state

46f2ded

feat(freeze-thaw): default is reject frozen (code review feedback)

ab7ddbc

yoldas requested a review from sabrine33 July 6, 2026 20:12

sabrine33 reviewed Jul 7, 2026

View reviewed changes

yoldas added 3 commits July 8, 2026 02:22

test(freeze-thaw): remove redundant empty select for no previously up…

789b43f

…loaded file case (review feeadback)

test(freeze-thaw): remove redundant rejectFrozen prop now that it def…

1c66096

…aults to true

fix(freeze-thaw): reset RecordInPlace state when switching thaw and c…

43bf4bf

…ryopreserve

yoldas and others added 6 commits July 8, 2026 12:39

revert(freeze-thaw): restore snapshot-based previous-length tracking …

4a41604

…in LabwareScanner; instead of refs

experimental

4038719

fix composedLabwareCheck

d005580

Merge remote-tracking branch 'origin/x1536-freeze-thaw' into x1536-fr…

4cc5044

…eeze-thaw # Conflicts: # src/components/labwareScanner/LabwareScanner.tsx # src/lib/machines/labware/labwareMachine.ts

move rejectFrozen check to the labwaremachine

87991bb

revert as committed by mistake

e748272

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

X1536 freeze thaw#1203

X1536 freeze thaw#1203
yoldas wants to merge 50 commits into
develfrom
x1536-freeze-thaw

yoldas commented Jun 15, 2026 •

edited

Loading

Uh oh!

yoldas commented Jun 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yoldas commented Jul 6, 2026

Uh oh!

sabrine33 commented Jul 6, 2026 •

edited

Loading

Uh oh!

sabrine33 commented Jul 7, 2026

Uh oh!

Uh oh!

Uh oh!

sabrine33 Jul 7, 2026

Uh oh!

yoldas Jul 8, 2026

Uh oh!

yoldas commented Jul 8, 2026

Uh oh!

yoldas commented Jul 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

yoldas commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed in this pull request

Instructions for Reviewers

Uh oh!

yoldas commented Jun 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yoldas commented Jul 6, 2026

Uh oh!

sabrine33 commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sabrine33 commented Jul 7, 2026

Uh oh!

Uh oh!

Uh oh!

sabrine33 Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

yoldas Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

yoldas commented Jul 8, 2026

Uh oh!

yoldas commented Jul 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yoldas commented Jun 15, 2026 •

edited

Loading

sabrine33 commented Jul 6, 2026 •

edited

Loading