Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sanity): add Rendering Context Store #8590

Draft
wants to merge 18 commits into
base: next
Choose a base branch
from

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Feb 11, 2025

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 11:08pm
performance-studio ❌ Failed (Inspect) 💬 Add feedback Feb 12, 2025 11:08pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 11:08pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 11:08pm
test-next-studio ⬜️ Ignored (Inspect) Feb 12, 2025 11:08pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 11, 2025

⚡️ Editor Performance Report

Updated Wed, 12 Feb 2025 23:15:12 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 25.0 efps (40ms) 25.3 efps (40ms) -1ms (-1.3%)
article (body) 71.9 efps (14ms) 71.7 efps (14ms) +0ms (-/-%)
article (string inside object) 27.0 efps (37ms) 26.3 efps (38ms) +1ms (+2.7%)
article (string inside array) 23.8 efps (42ms) 23.3 efps (43ms) +1ms (+2.4%)
recipe (name) 50.0 efps (20ms) 41.7 efps (24ms) +4ms (+20.0%) 🔴
recipe (description) 52.6 efps (19ms) 47.6 efps (21ms) +2ms (+10.5%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 19.0 efps (53ms) 19.8 efps (51ms) -2ms (-3.8%)
synthetic (string inside object) 18.9 efps (53ms) 20.0 efps (50ms) -3ms (-5.7%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 40ms 44ms 52ms 263ms 317ms 11.8s
article (body) 14ms 17ms 20ms 254ms 324ms 5.7s
article (string inside object) 37ms 39ms 44ms 149ms 119ms 6.7s
article (string inside array) 42ms 44ms 48ms 174ms 127ms 7.0s
recipe (name) 20ms 21ms 24ms 69ms 0ms 7.3s
recipe (description) 19ms 20ms 22ms 27ms 0ms 4.5s
recipe (instructions) 6ms 8ms 9ms 11ms 0ms 3.2s
synthetic (title) 53ms 57ms 60ms 401ms 1217ms 13.9s
synthetic (string inside object) 53ms 55ms 60ms 451ms 1413ms 8.8s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 40ms 43ms 49ms 591ms 369ms 12.0s
article (body) 14ms 16ms 28ms 169ms 335ms 6.2s
article (string inside object) 38ms 40ms 43ms 147ms 172ms 6.8s
article (string inside array) 43ms 47ms 51ms 148ms 282ms 7.0s
recipe (name) 24ms 28ms 38ms 69ms 48ms 9.2s
recipe (description) 21ms 23ms 27ms 52ms 4ms 5.2s
recipe (instructions) 6ms 8ms 9ms 9ms 0ms 3.1s
synthetic (title) 51ms 57ms 69ms 333ms 1305ms 12.9s
synthetic (string inside object) 50ms 54ms 65ms 419ms 1023ms 8.2s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Component Testing Report Updated Feb 12, 2025 11:15 PM (UTC)

❌ Failed Tests (3) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 57s 4 0 2
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 35s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 5s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 2m 24s 20 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor Author

juice49 commented Feb 11, 2025

rexxars and others added 17 commits February 11, 2025 17:38
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants