Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): update so that there is an horizontal scroll on the title #8710

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

refactor(core): update so that there is an horizontal scroll on the title #8710

wants to merge 1 commit into from

Conversation

RitaDias
Copy link
Contributor

Description

Before
image

After

Screen.Recording.2025-02-20.at.12.03.13.mov

What to review

Does it make sense, anything look odd?

Testing

Not needed

Notes for release

Improvements to document header when there are many versions of a document

@vercel Vercel
Copy link

vercel bot commented Feb 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 11:09am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 11:09am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 11:09am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 20, 2025 11:09am
test-next-studio ⬜️ Ignored (Inspect) Feb 20, 2025 11:09am

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 43% 54991 / 127882
🔵 Statements 43% 54991 / 127882
🔵 Functions 48.14% 2796 / 5807
🔵 Branches 79.48% 10634 / 13378
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/sanity/src/structure/panes/document/documentPanel/header/DocumentPanelHeader.tsx 10.65% 100% 0% 10.65% 42-244, 254-270, 278-312
Generated in workflow #30760 for commit f0855d3 by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link
Contributor

⚡️ Editor Performance Report

Updated Thu, 20 Feb 2025 11:16:36 GMT

Benchmark reference
latency of sanity@latest		 experiment
latency of this branch		 Δ (%)
latency difference
article (title) 26.3 efps (38ms) 27.0 efps (37ms) -1ms (-2.6%) ✅
article (body) 67.6 efps (15ms) 67.6 efps (15ms) +0ms (-/-%) ✅
article (string inside object) 26.3 efps (38ms) 28.6 efps (35ms) -3ms (-7.9%) ✅
article (string inside array) 24.1 efps (42ms) 24.4 efps (41ms) -1ms (-1.2%) ✅
recipe (name) 47.6 efps (21ms) 50.0 efps (20ms) -1ms (-4.8%) ✅
recipe (description) 55.6 efps (18ms) 55.6 efps (18ms) +0ms (-/-%) ✅
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (5ms) -1ms (-/-%) ✅
synthetic (title) 19.0 efps (53ms) 20.0 efps (50ms) -3ms (-4.8%) ✅
synthetic (string inside object) 19.2 efps (52ms) 19.6 efps (51ms) -1ms (-1.9%) ✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 38ms 66ms 80ms 518ms 846ms 10.9s
article (body) 15ms 17ms 32ms 173ms 483ms 6.2s
article (string inside object) 38ms 42ms 46ms 86ms 368ms 7.2s
article (string inside array) 42ms 43ms 48ms 153ms 232ms 7.0s
recipe (name) 21ms 23ms 25ms 44ms 9ms 7.5s
recipe (description) 18ms 20ms 22ms 92ms 2ms 4.7s
recipe (instructions) 6ms 8ms 10ms 13ms 0ms 3.2s
synthetic (title) 53ms 56ms 65ms 374ms 1168ms 12.6s
synthetic (string inside object) 52ms 61ms 72ms 403ms 1004ms 8.3s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 37ms 41ms 57ms 434ms 666ms 10.0s
article (body) 15ms 17ms 24ms 202ms 233ms 5.5s
article (string inside object) 35ms 38ms 42ms 176ms 277ms 6.7s
article (string inside array) 41ms 42ms 45ms 51ms 19ms 6.5s
recipe (name) 20ms 22ms 24ms 42ms 4ms 7.0s
recipe (description) 18ms 19ms 21ms 36ms 0ms 4.6s
recipe (instructions) 5ms 7ms 8ms 21ms 0ms 3.2s
synthetic (title) 50ms 52ms 57ms 197ms 553ms 12.2s
synthetic (string inside object) 51ms 53ms 62ms 222ms 409ms 7.7s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@github-actions GitHub Actions
Copy link
Contributor

Component Testing Report Updated Feb 20, 2025 11:20 AM (UTC)

❌ Failed Tests (4) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 19s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 2m 41s 3 0 3
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 58s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 17s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 16s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 51s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ❌ Failed (Inspect) 2m 59s 20 0 1
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 15s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 59s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@RitaDias RitaDias marked this pull request as ready for review February 20, 2025 13:01
@RitaDias RitaDias requested a review from a team as a code owner February 20, 2025 13:01
@RitaDias RitaDias requested review from cngonzalez and juice49 and removed request for a team and cngonzalez February 20, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juice49 juice49 Awaiting requested review from juice49

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RitaDias