Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Refactor/corel nicer org limits #8719

Draft
wants to merge 38 commits into
base: next
Choose a base branch
from
Draft

WIP: Refactor/corel nicer org limits #8719

wants to merge 38 commits into from

Conversation

jordanl17
Copy link
Member

Description

What to review

Testing

Notes for release

@jordanl17
feat(releases): initial support for stubbed org level release limits
cdbba4c
@jordanl17
refactor: removing datasetLimit from cache and just using cacheValue
53e38c2
@jordanl17
fix: caching when activeReleases is at the org level limit too
d3c8a78
@jordanl17
feat(releases): initial support for stubbed org level release limits
8d53373
@jordanl17
chore: types
010ec5f
@jordanl17
refactor: splitting separate stores for limits and count
2e5e89f
@jordanl17
refactor: further splitting of the stores
2b8b30c
@jordanl17
refactor: minor renaming
113bf18
@jordanl17
refactor: useOrgActiveReleaseCount only stores the count, nothing else
92b4796
@jordanl17
fix: using a shared network request in guard
9436e94
@jordanl17
refactor: tidy and reinstating useObservable
2f5265d
@jordanl17
refactor: all working; minor refactor to tidy
ea698cf
@jordanl17
refactor: updated useOrgActiveReleaseCount using a createStore
deb03cf
@jordanl17
refactor: useReleaseLimits uses a createStore
91e5405
@jordanl17
refactor: using the count of org active releases from the store direc…
6af633c 
…tly to interpolate on upsell
@jordanl17
feat: storing fetching state and error state for useReleaseLimits
9694ffc
@jordanl17
refactor: updating useReleaseLimits to use single subject for fetch s…
78f8f37 
…tate
@jordanl17
refactor: renaming
9409d93
@jordanl17
refactor: to using more reactivity
f8f7453
@jordanl17
refactor: tidy to logic layout in ReleasesUpsellProvider
b46b722
@jordanl17
fix: correcting issue that meant guard would always call cb
7a4ce41
@jordanl17
fix: resolving type errors
cf05702
@jordanl17
fix: resolving more TS issues
bbcdde7
@jordanl17
fix: resolving onLimitReached cb to not exec if dryRun
cdf4808
@jordanl17
chore: toggle stub or real API
a094e3d
@jordanl17
feat: using actual data response from API
1ffffd6
@jordanl17
fix: handling error from backend that still has data
bcc45fe
@jordanl17
feat: using the defaultActiveLimit to determine releases+
c03e227
@jordanl17
refactor: minor clarification on comments; reverting changes to inter…
09f66ec 
…polation for UpsellDialog
@jordanl17
refactor: reusing single type from fetchReleaseLimits; handling 404 e…
440c4b0 
…rrors gracefully
@vercel Vercel
Copy link

vercel bot commented Feb 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ❌ Failed (Inspect) Feb 21, 2025 11:58am
performance-studio ❌ Failed (Inspect) Feb 21, 2025 11:58am
test-studio ❌ Failed (Inspect) Feb 21, 2025 11:58am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 21, 2025 11:58am
test-next-studio ⬜️ Ignored (Inspect) Feb 21, 2025 11:58am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordanl17 @juice49