You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the core app template to use the proper components for wrapping a core app. This is iterative, and likely not the final state of what this template looks like.
What to review
Does this seem all right as an initial intro to core apps for internal parties?
Testing
I'm running into issues with cutting a canary -- I ran into some kind of cache issue where any canary I released was seen as "already published". I can try again on Monday.
efps — editor "frames per second". The number of updates assumed to be possible within a second.
Derived from input latency. efps = 1000 / input_latency
Detailed information
🏠 Reference result
The performance result of sanity@latest
Benchmark
latency
p75
p90
p99
blocking time
test duration
recipe (name)
20ms
21ms
26ms
40ms
0ms
7.4s
recipe (description)
18ms
19ms
21ms
40ms
0ms
4.5s
recipe (instructions)
5ms
7ms
8ms
18ms
0ms
3.1s
synthetic (title)
54ms
56ms
67ms
294ms
1004ms
13.1s
synthetic (string inside object)
49ms
52ms
61ms
230ms
885ms
8.6s
🧪 Experiment result
The performance result of this branch
Benchmark
latency
p75
p90
p99
blocking time
test duration
recipe (name)
23ms
24ms
27ms
45ms
6ms
7.5s
recipe (description)
20ms
21ms
22ms
64ms
0ms
5.0s
recipe (instructions)
5ms
7ms
8ms
17ms
0ms
3.1s
synthetic (title)
52ms
56ms
60ms
195ms
843ms
12.3s
synthetic (string inside object)
50ms
55ms
60ms
468ms
1060ms
8.5s
📚 Glossary
column definitions
benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
test duration — how long the test run took to complete.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the core app template to use the proper components for wrapping a core app. This is iterative, and likely not the final state of what this template looks like.
What to review
Does this seem all right as an initial intro to core apps for internal parties?
Testing
I'm running into issues with cutting a canary -- I ran into some kind of cache issue where any canary I released was seen as "already published". I can try again on Monday.
Notes for release
None, internal.