Skip to content

Commit 0d91c92

Browse files
ntkmenex3
andauthored
Support CompileRequest.silent of embedded protocol (#2160)
Co-authored-by: Natalie Weizenbaum <[email protected]>
1 parent b263a72 commit 0d91c92

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
### Embedded Sass
44

5+
* Support the `CompileRequest.silent` field. This allows compilations with no
6+
logging to avoid unnecessary request/response cycles.
7+
58
* The Dart Sass embedded compiler now reports its name as "dart-sass" rather
69
than "Dart Sass", to match the JS API's `info` field.
710

lib/src/embedded/compilation_dispatcher.dart

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import 'package:path/path.dart' as p;
1212
import 'package:protobuf/protobuf.dart';
1313
import 'package:sass/sass.dart' as sass;
1414

15+
import '../logger.dart';
1516
import '../value/function.dart';
1617
import '../value/mixin.dart';
1718
import 'embedded_sass.pb.dart';
@@ -117,8 +118,10 @@ final class CompilationDispatcher {
117118
var style = request.style == OutputStyle.COMPRESSED
118119
? sass.OutputStyle.compressed
119120
: sass.OutputStyle.expanded;
120-
var logger = EmbeddedLogger(this,
121-
color: request.alertColor, ascii: request.alertAscii);
121+
var logger = request.silent
122+
? Logger.quiet
123+
: EmbeddedLogger(this,
124+
color: request.alertColor, ascii: request.alertAscii);
122125

123126
try {
124127
var importers = request.importers.map((importer) =>

0 commit comments

Comments
 (0)