New Custom Step : SharePoint custom steps added - #258
Conversation
SharePoint custom steps added
|
Signed-off-by: Mayur Jadhav (mayur.jadhav@posten.no/mrmayurj28@gmail.com) |
MayurJadhavPage
left a comment
There was a problem hiding this comment.
Signed-off-by: Mayur Jadhav (mayur.jadhav@posten.no/mrmayurj28@gmail.com)
Signed-off-by: Mayur Jadhav <43246641+MayurJadhavPage@users.noreply.github.com>
DCO Remediation Commit for Mayur Jadhav <43246641+MayurJadhavPage@users.noreply.github.com> I, Mayur Jadhav <43246641+MayurJadhavPage@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 05296f0 I, Mayur Jadhav <43246641+MayurJadhavPage@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 644844a Signed-off-by: Mayur Jadhav <43246641+MayurJadhavPage@users.noreply.github.com>
|
Hi @MayurJadhavPage , Thank you for your contribution and congratulations on your first contribution to the sassoftware/sas-studio-custom-steps repository. I'm a maintainer of this repo (we've chatted offline) and over the next week, I shall review these steps and get back to you with suggestions through this conversation. Please allow for some time for us to review as we do this on a part-time basis. Regards, |
SundareshSankaran
left a comment
There was a problem hiding this comment.
Hi @MayurJadhavPage ,
Some initial changes requested, notably the request to split this into three folders (for the three steps) and to retain the _template folder. I shall continue with the review in parallel.
| --- | ||
|
|
||
| ## Change Log | ||
| * **Version 1.0** (2026) |
There was a problem hiding this comment.
Hi @MayurJadhavPage , request to follow DDMONYYYY for version dates to help standardisation. So your step would be something on the lines of 16JUN2026 (or whenever the custom step was last modified). Thanks.
| ## Change Log | ||
| * **Version 1.0** (2026) | ||
| * Initial release of the SharePoint custom step suite | ||
| * Includes three steps: **SharePoint - Token Generator**, **SharePoint - Token Refresh**, and **SharePoint - File Import Export** |
There was a problem hiding this comment.
Hi @MayurJadhavPage , our first major changes requested.
We follow a practice of one step per folder in this repository. Our request is to change your PR to include three folders for the three steps,
- SharePoint - Generate Token
- SharePoint - Refresh Token
- SharePoint - Import or Export Files
The folder names are keeping with a standard of "action verbs" we want to establish for all steps.
Each step folder has its own individual README. You can definitely make those READMEs for Generate Token and Refresh Token as brief as possible and mention that they support the main step (Import or Export Files). Thank you.
There was a problem hiding this comment.
Hi @MayurJadhavPage , the _template folder is not meant to be deleted. Request if you could add it back. When we merge your pulls in current state, the _template folder will disappear for all users. Thank you.
Please include answers to these questions as part of your pull request
In the GitHub webUI, use the Write tab to modify the Markdown text that is part of the pull request. For each question simply place an X inside the square brackets, [X], that represents your answer. Make sure there are no blanks inside the brackets, otherwise MarkDown doesn't render properly. Using the Preview tab while editing this form, you can see the formatted/rendered version of the message.
ContributorAgreement.SharePoint.MayurJadhav.txt