Skip to content

New Custom Step : SharePoint custom steps added - #258

Open
MayurJadhavPage wants to merge 4 commits into
sassoftware:mainfrom
MayurJadhavPage:main
Open

New Custom Step : SharePoint custom steps added#258
MayurJadhavPage wants to merge 4 commits into
sassoftware:mainfrom
MayurJadhavPage:main

Conversation

@MayurJadhavPage

@MayurJadhavPage MayurJadhavPage commented Jun 16, 2026

Copy link
Copy Markdown

Please include answers to these questions as part of your pull request

In the GitHub webUI, use the Write tab to modify the Markdown text that is part of the pull request. For each question simply place an X inside the square brackets, [X], that represents your answer. Make sure there are no blanks inside the brackets, otherwise MarkDown doesn't render properly. Using the Preview tab while editing this form, you can see the formatted/rendered version of the message.

  • Q1: Confirm that you have the right to submit the code that is being contributed. Please consider the origin of your code and confirm you have the appropriate rights to make the submission subject to the Apache 2.0 license that applies to everything in this repository of custom steps. If so, follow the instructions for the Contributor Agreement (which is based on the industry-standard Developer Certificate of Origin (DCO)).
    • Yes, I have the right to submit the contributed code on behalf of myself, my company, or any other owner of the code. I have also attached my signed copy of the DCO to this message.
    • No
  • Q2: Confirm that your contribution does not include any personally identifiable information (PII), for example, in any examples used in your README file.
    • My contribution does NOT include PII data
    • My contribution includes PII data
  • Q3: Confirm your contribution does not include any encryption or other export-controlled technology.

@MayurJadhavPage

Copy link
Copy Markdown
Author

Signed-off-by: Mayur Jadhav (mayur.jadhav@posten.no/mrmayurj28@gmail.com)

@MayurJadhavPage MayurJadhavPage left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Mayur Jadhav (mayur.jadhav@posten.no/mrmayurj28@gmail.com)

Signed-off-by: Mayur Jadhav <43246641+MayurJadhavPage@users.noreply.github.com>
DCO Remediation Commit for Mayur Jadhav <43246641+MayurJadhavPage@users.noreply.github.com>

I, Mayur Jadhav <43246641+MayurJadhavPage@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 05296f0
I, Mayur Jadhav <43246641+MayurJadhavPage@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 644844a

Signed-off-by: Mayur Jadhav <43246641+MayurJadhavPage@users.noreply.github.com>
@SundareshSankaran

Copy link
Copy Markdown
Collaborator

Hi @MayurJadhavPage ,

Thank you for your contribution and congratulations on your first contribution to the sassoftware/sas-studio-custom-steps repository. I'm a maintainer of this repo (we've chatted offline) and over the next week, I shall review these steps and get back to you with suggestions through this conversation. Please allow for some time for us to review as we do this on a part-time basis.

Regards,
Sundaresh

@SundareshSankaran SundareshSankaran added good first issue Good for newcomers new custom step This pull request represents a new custom step labels Jun 16, 2026
@SundareshSankaran SundareshSankaran changed the title SharePoint custom steps added New Custom Step : SharePoint custom steps added Jun 16, 2026

@SundareshSankaran SundareshSankaran left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MayurJadhavPage ,

Some initial changes requested, notably the request to split this into three folders (for the three steps) and to retain the _template folder. I shall continue with the review in parallel.

Comment thread SharePoint/README.md
---

## Change Log
* **Version 1.0** (2026)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MayurJadhavPage , request to follow DDMONYYYY for version dates to help standardisation. So your step would be something on the lines of 16JUN2026 (or whenever the custom step was last modified). Thanks.

Comment thread SharePoint/README.md
## Change Log
* **Version 1.0** (2026)
* Initial release of the SharePoint custom step suite
* Includes three steps: **SharePoint - Token Generator**, **SharePoint - Token Refresh**, and **SharePoint - File Import Export**

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MayurJadhavPage , our first major changes requested.

We follow a practice of one step per folder in this repository. Our request is to change your PR to include three folders for the three steps,

  • SharePoint - Generate Token
  • SharePoint - Refresh Token
  • SharePoint - Import or Export Files

The folder names are keeping with a standard of "action verbs" we want to establish for all steps.

Each step folder has its own individual README. You can definitely make those READMEs for Generate Token and Refresh Token as brief as possible and mention that they support the main step (Import or Export Files). Thank you.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MayurJadhavPage , the _template folder is not meant to be deleted. Request if you could add it back. When we merge your pulls in current state, the _template folder will disappear for all users. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers new custom step This pull request represents a new custom step

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants