Skip to content

Fix signature verification - #48

Open
fauresebast wants to merge 5 commits into
savonrb:mainfrom
pennylane-hq:sf/fix-signature-verification
Open

Fix signature verification#48
fauresebast wants to merge 5 commits into
savonrb:mainfrom
pennylane-hq:sf/fix-signature-verification

Conversation

@fauresebast

@fauresebast fauresebast commented Jul 31, 2025

Copy link
Copy Markdown

AS4 message

  • have a couple of "//wse:Security/wse:BinarySecurityToken" so we need to extract the correct one during signature validation
  • may have ds:Reference for attachments, not following the other Reference validation and must be checked outside

@fauresebast
fauresebast marked this pull request as ready for review July 31, 2025 09:21
NathanBerthier
NathanBerthier approved these changes Jul 31, 2025
View reviewed changes

@NathanBerthier NathanBerthier left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 💪

Comment thread lib/akami/wsse/verify_signature.rb Outdated
@thromera

thromera commented Aug 5, 2025

Copy link
Copy Markdown

Nice

@fauresebast
fauresebast force-pushed the sf/fix-signature-verification branch from c6577e7 to be41233 Compare August 7, 2025 10:29
@fauresebast
fauresebast force-pushed the sf/fix-signature-verification branch from be41233 to 07e8524 Compare August 7, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@NathanBerthier NathanBerthier NathanBerthier approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fauresebast @thromera @NathanBerthier