Skip to content

Conversation

gaeljw
Copy link
Contributor

@gaeljw gaeljw commented Oct 6, 2025

Includes:

  • dropping support for Java < 17 as Junit 6 is requires
  • removed integration test that was using junit-platform-runner (removed in JUnit 6), it was the module to integrate with JUnit 4 (not exactly clear to me the difference with Junit Vintage TBH)

Note that in JUnit 6, all versions of all artifacts are aligned (see https://github.com/junit-team/junit-framework/wiki/Upgrading-to-JUnit-6.0). We no longer need specific versions for JUnit platform vs. Jupiter for instance.

Closes #188 and #189

@gaeljw gaeljw force-pushed the feature/support-junit-6 branch 2 times, most recently from c06271e to f15b655 Compare October 6, 2025 16:16
@gaeljw
Copy link
Contributor Author

gaeljw commented Oct 6, 2025

Oops, there's some additional changes to do. I'll fix that tomorrow.

@gaeljw gaeljw changed the title ✨ feat: support Junit 6 Draft: ✨ feat: support Junit 6 Oct 6, 2025
@gaeljw gaeljw force-pushed the feature/support-junit-6 branch from dd2e43f to 0cdbe6b Compare October 7, 2025 11:30
@gaeljw gaeljw changed the title Draft: ✨ feat: support Junit 6 ✨ feat: support Junit 6 Oct 7, 2025
@gaeljw
Copy link
Contributor Author

gaeljw commented Oct 7, 2025

Ready for review :)

@gaeljw
Copy link
Contributor Author

gaeljw commented Oct 7, 2025

For the record, I've also tested this development on a project of mine at work and it does work.

@eed3si9n
Copy link
Member

eed3si9n commented Oct 7, 2025

Thanks for the contribution. Let me release whatever we have on the main branch first, and I'll try to land this soon right afterwards.

@eed3si9n eed3si9n mentioned this pull request Oct 7, 2025
@eed3si9n eed3si9n merged commit bed340a into sbt:main Oct 8, 2025
3 checks passed
dongjoon-hyun added a commit to apache/spark that referenced this pull request Oct 10, 2025
### What changes were proposed in this pull request?

This PR aims to upgrade `sbt-jupiter-interfac` to `0.17.0`.

### Why are the changes needed?

To bring the latest improvements including JUnit 6 support.

- https://github.com/sbt/sbt-jupiter-interface/releases/tag/v0.17.0 (2025-10-09)
  - sbt/sbt-jupiter-interface#194

- https://github.com/sbt/sbt-jupiter-interface/releases/tag/v0.16.0 (2025-10-08)
  - sbt/sbt-jupiter-interface#186

### Does this PR introduce _any_ user-facing change?

No behavior change because this is a test dependency.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #52562 from dongjoon-hyun/SPARK-53860.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants