Skip to content

Conversation

haveo
Copy link
Contributor

@haveo haveo commented Nov 6, 2024

Follow-up to #123 by @raboof, sbt has been updated to 1.10.5 so this shouldn't be blocked anymore.

@haveo haveo marked this pull request as ready for review November 6, 2024 13:55
@raboof
Copy link
Contributor

raboof commented Nov 7, 2024

Thanks for doing the merge, great to see CI indeed succeeding now!

This probably means that, after this change, sbt-license-report only works correctly when the project is also using sbt 1.10.5 or later. We should probably document that. Do you think we should also put in a technical safeguard? I'd say documenting it is probably sufficient.

@raboof
Copy link
Contributor

raboof commented Nov 11, 2024

fixes #87

@haveo
Copy link
Contributor Author

haveo commented Nov 11, 2024

Thanks for doing the merge, great to see CI indeed succeeding now!

This probably means that, after this change, sbt-license-report only works correctly when the project is also using sbt 1.10.5 or later. We should probably document that. Do you think we should also put in a technical safeguard? I'd say documenting it is probably sufficient.

I guess it's it's also possible to check sbt's version and use the old implementation if sbt is not new enough. I'm not so sure it's worth it however. But I think we need at least a warning / error if the sbt version is too old.

Copy link
Contributor

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for adding that! AFAICS this should now be good to go.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land this!

@eed3si9n eed3si9n merged commit 10d9dd3 into sbt:main Aug 18, 2025
13 checks passed
@eed3si9n eed3si9n mentioned this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants