Skip to content

WIP: Update Mill build tooling #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lefou
Copy link
Member

@lefou lefou commented May 7, 2025

  • Update mill bootstrap script to 0.13.0-M2-3-ba7090
  • Update Mill from 0.11.13 to 0.12.10
  • Update Java setup - Mill 0.12 required Java 11 at build time, but the project should still support running on Java 8 at runtime.
  • mill-integrationtest plugin doesn't work out-of-the-box with Mill 0.12
  • Renew build script, fix deprecations

@lefou lefou changed the title Update Mill build tooling WIP: Update Mill build tooling May 7, 2025
@ghostbuster91
Copy link

Hey,
just saw this PR - looks like it would fix an issue we're currently facing at work. I noticed there hasn’t been much activity recently, and totally understand if it’s just a matter of not having the time (we've all been there 😄).

If you're open to it, we'd be happy to help push this over the finish line. Let us know if that would be helpful - or if you already have something in the works.

Thanks for getting this started in the first place!

@lefou
Copy link
Member Author

lefou commented May 19, 2025

@ghostbuster91 I haven't worked on this, so please feel free to move forward. Your help is greatly appreciated!

Just to be clear, this PR is about building this plugin with a newer Mill version. It's not about building this plugin for a newer Mill version (e.g. 1.0), which can be perfectly done without bumping Mill for now.

It would be interesting though, which issue the update might fix for you? If you have an issue with this plugin, opening a new issue might be the best way to start getting it fixed, beside contributing the fix.

@ghostbuster91
Copy link

@lefou Got it, thanks! The issue on our end is that we’re using Mill 0.12, which the current version of the plugin doesn’t support.

As far as I can tell, there’s currently no PR that adds 0.12 support, so if you don’t mind, we’ll pick this effort up and create one.

@lefou
Copy link
Member Author

lefou commented May 19, 2025

@lefou Got it, thanks! The issue on our end is that we’re using Mill 0.12, which the current version of the plugin doesn’t support.

As far as I can tell, there’s currently no PR that adds 0.12 support, so if you don’t mind, we’ll pick this effort up and create one.

Please open an issue for it and include the error message. To my knowledge, this plugin does work with Mill 0.12. We don't have integration tests for it, but I think I saw it opening pull requests against projects using Mill 0.12. Mill 0.12 uses the same binary platform as Mill 0.11 and plugins should be compatible.

Related:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants