Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logback-classic only on 1.3.x series that supports JDK 8 #2745

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Oct 20, 2022

Supersedes #2719

logback-classic no longer supports JDK 8 starting from 1.4.0.
image

Let's pin it to 1.3.x series until we drop JDK 8 support.

@exoego exoego requested a review from a team October 20, 2022 05:12
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 80.54% // Head: 80.62% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (68ee22b) compared to base (6fadfce).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2745      +/-   ##
==========================================
+ Coverage   80.54%   80.62%   +0.07%     
==========================================
  Files         146      147       +1     
  Lines        2709     2740      +31     
  Branches      168      176       +8     
==========================================
+ Hits         2182     2209      +27     
- Misses        527      531       +4     
Impacted Files Coverage Δ
...la/org/scalasteward/core/application/Context.scala 68.00% <0.00%> (-2.59%) ⬇️
...org/scalasteward/core/application/StewardAlg.scala 42.42% <0.00%> (-1.70%) ⬇️
.../scala/org/scalasteward/core/application/Cli.scala 100.00% <0.00%> (ø)
...teward/core/repoconfig/ValidateRepoConfigAlg.scala 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@alejandrohdezma alejandrohdezma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just curious, what's holding us back from dropping support for JDK 8?

@exoego
Copy link
Contributor Author

exoego commented Oct 20, 2022

Good question.
Actually I do not know.

Since Scala Steward is an app and not a library to be used in "enterprise" app, it might be easy for users, who hosted their own Steward, to run Steward on Java 11.

@exoego exoego mentioned this pull request Oct 20, 2022
@exoego
Copy link
Contributor Author

exoego commented Oct 20, 2022

I've opened #2746 to consider dropping Java 8

@exoego exoego merged commit a80b77c into scala-steward-org:main Oct 20, 2022
@exoego exoego deleted the suppress-logback-classic branch October 20, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants