Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Java 8 with newer LTS Java 17 #2779

Merged
merged 1 commit into from
Nov 20, 2022

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Nov 18, 2022

Closes #2746

Unfortunately, not a small number of libraries used in Scala Steward dropped Java 8.
Since scala-steward is not a library, I think long-term Java 8 support is not needed fundamentally.

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 80.58% // Head: 80.58% // No change to project coverage 👍

Coverage data is based on head (b9d4718) compared to base (b9d4718).
Patch has no changes to coverable lines.

❗ Current head b9d4718 differs from pull request most recent head 4c726d7. Consider uploading reports for the commit 4c726d7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2779   +/-   ##
=======================================
  Coverage   80.58%   80.58%           
=======================================
  Files         149      149           
  Lines        2849     2849           
  Branches      198      198           
=======================================
  Hits         2296     2296           
  Misses        553      553           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@exoego exoego marked this pull request as ready for review November 18, 2022 02:05
@exoego exoego requested a review from a team November 18, 2022 02:05
Copy link
Member

@alejandrohdezma alejandrohdezma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we do the same with Java 11 and only support 17?

@exoego
Copy link
Contributor Author

exoego commented Nov 19, 2022

@alejandrohdezma
That is a good point.
I want to propose "last two LTS" strategy so it gives some time to prepare to users.
WDYT?

@alejandrohdezma
Copy link
Member

Yeah, sounds like a sensible idea 😸

@exoego exoego merged commit 7052507 into scala-steward-org:main Nov 20, 2022
@exoego exoego deleted the drop-java8 branch November 20, 2022 01:26
@exoego exoego added this to the 0.16.0 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Java 8 Support
2 participants