Skip to content

add ghUpload for publishing to GitHub releases #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 9, 2025
Merged

Conversation

lrytz
Copy link
Member

@lrytz lrytz commented May 7, 2025

No description provided.

@lrytz
Copy link
Member Author

lrytz commented May 7, 2025

it seems we have been publishing to s3 for every nightly. that was probably never intended? @SethTisue

didn't change that (yet) in this pr.

@lrytz
Copy link
Member Author

lrytz commented May 8, 2025

@lrytz
Copy link
Member Author

lrytz commented May 8, 2025

I tested it on a branch, it works. Uploaded a .zip from travis and a .msi from AppVeyor to https://github.com/scala/scala/releases/tag/v2.13.16.

@SethTisue
Copy link
Member

it seems we have been publishing to s3 for every nightly. that was probably never intended? @SethTisue

I have no recollection of what that might have been about

(might it have been a hedge against our Artifactory getting corrupted...?)

@lrytz
Copy link
Member Author

lrytz commented May 8, 2025

(might it have been a hedge against our Artifactory getting corrupted...?)

I really think this was just by accident...

tested it on a branch, upload to github works now.
@lrytz
Copy link
Member Author

lrytz commented May 9, 2025

I'll backport this to 2.12, that branch is still on sbt 0.13.

@lrytz lrytz merged commit cf30a4a into scala:2.13.x May 9, 2025
3 checks passed
@lrytz lrytz mentioned this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants