-
Notifications
You must be signed in to change notification settings - Fork 323
Explain version choice on download page #1791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
_layouts/download.html
Outdated
<h2>Which version of Scala should I choose?</h2> | ||
<p>There are 2 distribution lines of Scala 3:</p> | ||
<ul> | ||
<li><strong>Scala Next</strong> - The <strong>default</strong> to be used by most users, containing the latest features, bug fixes and improvements.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this perhaps can display the current LTS/Next version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good idea, I'm not sure how to implement it with this templating engine though 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its using jekyll for templating, (like ruby, variables magically exist when you define them)
maybe you can look at this snippet (how the frontpage renders the lts and next releases) which loops through all the "current releases" and then when it sees the right release assigns it to the appropriate variable, then you can splice later with {{scala_lts_version}}
scala-lang/_layouts/frontpage.html
Lines 48 to 62 in 37767b2
{% for release in site.data.scala-releases %} | |
{% assign version_slice = release.version | slice: 0, 2 %} | |
{% if release.category == 'current_version' %} | |
{% if version_slice == '3.' %} | |
{% unless release.title contains "LTS" %} | |
{% assign scala_next_release = release %} | |
{% endunless %} | |
{% if release.title contains "LTS" %} | |
{% assign scala_lts_release = release %} | |
{% endif %} | |
{% else %} | |
{% assign scala_2_version = release.version %} | |
{% endif %} | |
{% endif %} | |
{% endfor %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Jamie, that helped! the updated layout renders version numbers as on this screenshot:
@lrytz it also removes the sethian parentheses 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
_layouts/download.html
Outdated
<p>There are 2 distribution lines of Scala 3:</p> | ||
<ul> | ||
<li><strong>Scala Next</strong> - The <strong>default</strong> to be used by most users, containing the latest features, bug fixes and improvements.</li> | ||
<li><strong>Scala LTS</strong> - Advised to be used for publishing <strong>libraries</strong>. (Some especially conservative users might also choose it over Scala Next.)</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mabye without the sethian parentheses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me
<li><strong>Scala LTS</strong> - Advised to be used for publishing <strong>libraries</strong>. (Some especially conservative users might also choose it over Scala Next.)</li> | |
<li><strong>Scala LTS</strong> - Advised to be used for publishing <strong>libraries</strong>.</li> |
This is a follow up to #1790
Last year the advisory board has accepted https://github.com/scalacenter/advisoryboard/blob/main/proposals/032-scala-version-guidance.md that was later marked as completed in scalacenter/advisoryboard#164 by the introduction of https://scala-lang.org/development. While this page provides a clear guidance, it's very hard to find.
The proposal mentioned explaining version choice on the download page, this PR provides such guidance.