Skip to content

Backport "In selector check, prefix of reference must match import qualifier" to 3.3 LTS #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 21, 2025

Conversation

tgodzik
Copy link

@tgodzik tgodzik commented Apr 10, 2025

Backports scala#20894 to the 3.3.6.

PR submitted by the release tooling.

som-snytt and others added 6 commits April 10, 2025 17:04
Use miniphase api instead of traversing.

Share a megaphase with CheckShadowing.

Perform more expensive checks last. Avoid intermediate collections.

Tighten allowance for serialization methods.

Don't ignore params of public methods.

Show misplaced warn comment, unfulfilled expectations.

Warn for unused patvars.
Don't warn about canonical names (case class element names).
Warn unassigned mutable patvars

No transparent inline exclusion. Handle match types.
No warn inline proxy. Detect summon inline.

Unused import diagnostics have an origin.

Original of literal.

Typos in build. Handle aliased boolean settings.

Resolve imports post inlining.

Excuse only empty interfaces as unused bound.

Use result of TypeTest.
Use miniphase api instead of traversing.

Share a megaphase with CheckShadowing.

Perform more expensive checks last. Avoid intermediate collections.

Tighten allowance for serialization methods.

Don't ignore params of public methods.

Show misplaced warn comment, unfulfilled expectations.

Warn for unused patvars.
Don't warn about canonical names (case class element names).
Warn unassigned mutable patvars

No transparent inline exclusion. Handle match types.
No warn inline proxy. Detect summon inline.

Unused import diagnostics have an origin.

Original of literal.

Typos in build. Handle aliased boolean settings.

Resolve imports post inlining.

Excuse only empty interfaces as unused bound.

Use result of TypeTest.

[Cherry-picked c65d45d][modified]
[Cherry-picked a5d9e25][modified]
[Cherry-picked 6c2c5c5]
[Cherry-picked 152a8cd][modified]
@tgodzik tgodzik force-pushed the backport-lts-3.3-20894 branch from 221b87f to f2519e4 Compare April 19, 2025 10:55
@tgodzik
Copy link
Author

tgodzik commented Apr 21, 2025

No regressions detected in the community build up to backport-lts-3.3-22504.

Reference

@tgodzik tgodzik merged commit d2804a9 into lts-3.3 Apr 21, 2025
22 checks passed
@tgodzik tgodzik deleted the backport-lts-3.3-20894 branch April 21, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants