Check for tasty error in template trees. #22867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidaisy
force-pushed
the
error-in-template-body
branch
from
15a44fb to
fe86aee
Compare
olhotak
approved these changes
Apr 2, 2025
| @@ -654,6 +668,7 @@ object Semantic: | |||
| val methodType = atPhaseBeforeTransforms { meth.info.stripPoly } | |||
| var allArgsHot = true | |||
| val allParamTypes = methodType.paramInfoss.flatten.map(_.repeatedToSingle) | |||
| assert(allParamTypes.size == args.size) | |||
There was a problem hiding this comment.
Please make this an Internal Error instead of an assertion.
| @@ -43,6 +46,7 @@ object Util: | |||
| case Apply(fn, args) => | |||
| val argTps = fn.tpe.widen match | |||
| case mt: MethodType => mt.paramInfos | |||
| assert(args.size == argTps.size) | |||
There was a problem hiding this comment.
Same as above, Internal Error.
liufengyun
approved these changes
Apr 2, 2025
lidaisy
force-pushed
the
error-in-template-body
branch
from
fe86aee to
ccd9c22
Compare
|
@liufengyun @olhotak Can we merge this? |
Still waiting for a minor tweak. Please don't merge yet. |
lidaisy
force-pushed
the
error-in-template-body
branch
from
ccd9c22 to
884436f
Compare
|
@tgodzik This is now ready to be merged, but CI failed seemingly due to a flaky test. Need to re-run CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.