fix: clean up settings in the Build #24714
Open
+12
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
added
the
backport:nominated
| // Packaging configuration of the stdlib | ||
| Compile / packageBin / publishArtifact := true, | ||
| Compile / packageDoc / publishArtifact := false, | ||
| Compile / packageSrc / publishArtifact := true, | ||
| // Only publish compilation artifacts, no test artifacts | ||
| Compile / publishArtifact := true, | ||
| Test / publishArtifact := false, |
Contributor
There was a problem hiding this comment.
Can we start to deduplicate all the settings and set them in common settings group? Otherwise it's hard to review (need to expand the views to see to which projects given changes apply) and it's easy to forget about some. All of the published artifacts would use the same values for Compile/Test publishArtifacts, and multiple other settings.
We've had a dedicated publishSetting previously, it might be worthy to restore it.
Duplication of setting was useful during migration and to track changes, but it's hard to maintain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
classDirectoryfromscala3-library-*projects and some cleanups of the settings.Closes #24703