Use TypeComparer.constValue in TypeEval #24718
Open
+25
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses `TypeComparer.constValue` to extract the constant in TypeEval. This is also how constValue is implemented. So I think also using it in TypeEval make behavior around this more consistent and predictable. This fixes: scala#24717
eejbyfeldt
commented
Dec 10, 2025
|
|
||
| val a: 123 & O.O = O.v | ||
| val b: S[a.type] = 124 | ||
| val c: a.type + 1 = 124 |
Contributor
Author
There was a problem hiding this comment.
This introduces some inconsistency as
val d: a.type + 1 = a + 1
will still not compiles as a + 1 does not get constant folded.
Should ConstFold also use TypeComparer for extracting the constant type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
TypeComparer.constValueto extract the constant in TypeEval.This is also how constValue is implemented. So I think also using it in
TypeEval make behavior around this more consistent and predictable.
This fixes: #24717