Fixes #15830: Inline given with using parameter losing constant value#26020
Draft
soronpo wants to merge 1 commit into
Draft
Fixes #15830: Inline given with using parameter losing constant value#26020soronpo wants to merge 1 commit into
soronpo wants to merge 1 commit into
Conversation
) When inlining a method call on a receiver that itself was the result of inlining (e.g. summonInline of a given with using parameters), bindings of the inner inline are lifted out by liftBindings to wrap the outer inline. After further reduction the lifted bindings can become orphaned in the surrounding Block, defeating Expr#value/valueOrAbort because the constant expression is no longer recognized as such. Drop lifted bindings that have a pure rhs and are unreferenced in the expansion, iterating to a fixpoint to handle chains of dependent bindings.
soronpo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When inlining a method call on a receiver that itself was the result of inlining (e.g. summonInline of a given with using parameters), bindings of the inner inline are lifted out by liftBindings to wrap the outer inline. After further reduction the lifted bindings can become orphaned in the surrounding Block, defeating Expr#value/valueOrAbort because the constant expression is no longer recognized as such.
Drop lifted bindings that have a pure rhs and are unreferenced in the expansion, iterating to a fixpoint to handle chains of dependent bindings.
Fixes #15830
How much have you relied on LLM-based tools in this contribution?
Extensively. This change looks scary. Let's see what the CI says. Don't know if I'll remove the draft.
How was the solution tested?
New automated tests (including the issue's reproducer, if applicable)