Fixes #25806: Eta-expand partial app of integrated context-function result#26030
Draft
soronpo wants to merge 1 commit into
Draft
Fixes #25806: Eta-expand partial app of integrated context-function result#26030soronpo wants to merge 1 commit into
soronpo wants to merge 1 commit into
Conversation
…n result When an inline method is expanded with a concrete context-function type substituted for an abstract result type, the call site can be left with a call to a method whose `@ContextResultCount`-integrated signature has more parameters than the call supplies (because the result is consumed as a context-function value rather than immediately applied). At erasure, `adaptToType` previously asserted on this case. Instead, recover by eta-expanding the partial application to a closure that supplies the missing parameters, merging the new arguments into the existing call chain so later phases see a fully-applied inner Apply.
soronpo
changed the title
soronpo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an inline method is expanded with a concrete context-function type substituted for an abstract result type, the call site can be left with a call to a method whose
@ContextResultCount-integrated signature has more parameters than the call supplies (because the result is consumed as a context-function value rather than immediately applied). At erasure,adaptToTypepreviously asserted on this case. Instead, recover by eta-expanding the partial application to a closure that supplies the missing parameters, merging the new arguments into the existing call chain so later phases see a fully-applied inner Apply.Fixes #25806
How much have you relied on LLM-based tools in this contribution?
Extensively. Looks to be a significant change. Let's first see what the CI says, and I may decide to take it out of a draft state.
How was the solution tested?
New automated tests (including the issue's reproducer, if applicable)