Fix synthesis of mirrors for GADT with dependent type parameters#26080
Open
eejbyfeldt wants to merge 1 commit into
Open
Fix synthesis of mirrors for GADT with dependent type parameters#26080eejbyfeldt wants to merge 1 commit into
eejbyfeldt wants to merge 1 commit into
Conversation
Member
|
not really sure about these types, is a wildcard more appropriate? |
Contributor
Author
But that sounds like a different change? To me it seems this MR is not really changing that logic, just applying the current logic in a way that handles more cases. You will get similar (at least in my understanding) types if you do |
Member
|
yeah, i guess its fine then, i guess it might be worth having a type class derivation example test case as well. |
Contributor
Author
|
@bishabosha Added a type class derivation example, let me know if you feel is is motivating enough. |
This extends the current logic in Synthesizer.scala to instead of doing a single replacement do it until a fixed point is reached. Fixes: scala#23774
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends the current logic in Synthesizer.scala to instead of doing
a single replacement do it until a fixed point is reached.
Fixes #23774
How much have you relied on LLM-based tools in this contribution?
Extensively, for exploring the code base and determining where the issue was.
How was the solution tested?
New automated tests