Reviewing pull requests

Reviewing Pull Requests

Pull requests are the heart of our collaborative development. A thorough review process ensures the stability and quality of the Moo codebase.

For Contributors

Before submitting your PR, ensure:

1. DCO Compliance: Every commit has a Signed-off-by line (use git commit -s).
2. Formatting: Code is formatted using ./mvnw spotless:apply.
3. Null Safety: JSpecify annotations are correctly applied.
4. Tests: All tests pass locally and new logic is covered.
5. Documentation: Any API changes are reflected in Swagger and the Wiki.

For Reviewers

When reviewing a PR, look for:

• Architectural Integrity: Does it follow the Controller -> Service -> Repository pattern?
• Security: Is the user identity correctly extracted from Principal?
• Scalability: Are list endpoints properly paginated using Pageable?
• Clean Code: Is the logic simple, well-named, and free of qualified names inline?
• CI Status: Only merge PRs where all checks (lint, test, smoke-build) are green.

Merging Strategy

• We prefer Squash and Merge to keep the master branch history clean and concise.
• Merges to master automatically trigger the distribution pipeline.