Skip to content

feat(rdb): add command for instance settings #4677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

feat(rdb): add command for instance settings #4677

wants to merge 19 commits into from

Conversation

jremy42
Copy link
Contributor

@jremy42 jremy42 commented Apr 17, 2025 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

close #2946

@jremy42 jremy42 requested review from a team and remyleone as code owners April 17, 2025 14:18
@github-actions github-actions bot added the rdb Managed MySQL and PostgreSQL issues, bugs and feature requests label Apr 17, 2025
@jremy42 jremy42 changed the title Feat/rdb improve instance settings feat(rdb): add command for instance settings Apr 17, 2025
@jremy42 jremy42 force-pushed the feat/rdb_improve_instance_settings branch 5 times, most recently from 4945c45 to 4ce0a5c Compare April 18, 2025 12:59
@jremy42 jremy42 force-pushed the feat/rdb_improve_instance_settings branch from 4ce0a5c to 30fe940 Compare April 18, 2025 13:02
@jremy42 jremy42 force-pushed the feat/rdb_improve_instance_settings branch from b9c1141 to 131a650 Compare April 18, 2025 14:07
@jremy42 jremy42 force-pushed the feat/rdb_improve_instance_settings branch from f2795b4 to f69716c Compare April 22, 2025 08:33
remyleone
remyleone reviewed Apr 25, 2025
View reviewed changes
cmd/scw/testdata/test-all-usage-rdb-instance-edit-settings-usage.golden
You can modify the values and save the file to apply the new configuration.

USAGE:
scw rdb instance edit-settings <instance-id ...> [arg=value ...]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@jremy42 jremy42

Labels
rdb Managed MySQL and PostgreSQL issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for rdb instance settings edit
2 participants
@jremy42 @remyleone