Skip to content

feat(Navigation): nested menu when collapsed#6216

Open
lisalupi wants to merge 2 commits intomainfrom
feat/navigation-nested
Open

feat(Navigation): nested menu when collapsed#6216
lisalupi wants to merge 2 commits intomainfrom
feat/navigation-nested

Conversation

@lisalupi
Copy link
Collaborator

@lisalupi lisalupi commented Mar 16, 2026

Summary

Type

  • Bug
  • Enhancement
  • Refactor

Summarize concisely:

What is expected?

Navigation:

  • allow nested items and menus
  • add item parent label on top of menu to help navigation
  • add ... on menu disclosure when no categoryIcon is provided to avoid empty buttons
  • Refactor code to reduce complexity and improve legibility
Page Before After
Menu without category icon Capture d’écran 2026-03-16 à 11 17 00 Capture d’écran 2026-03-16 à 11 16 40
Nested item (nested items not shown when collapsed) Capture d’écran 2026-03-16 à 11 18 01 Capture d’écran 2026-03-16 à 11 18 22
Item group title (no item group name)Capture d’écran 2026-03-16 à 11 19 48 (has item group name) Capture d’écran 2026-03-16 à 11 20 23

@lisalupi lisalupi requested review from a team and mhervouet March 16, 2026 10:21
@lisalupi lisalupi self-assigned this Mar 16, 2026
@lisalupi lisalupi requested review from Echo-IV and alexandre-combemorel and removed request for a team March 16, 2026 10:21
@lisalupi lisalupi added bug Something isn't working enhancement New feature or request refactor Refactor without breaking changes labels Mar 16, 2026
@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2026

🦋 Changeset detected

Latest commit: b46aa4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ultraviolet/ui Minor
@ultraviolet/form Patch
@ultraviolet/nextjs Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lisalupi lisalupi force-pushed the feat/navigation-nested branch from b031291 to 6075eec Compare March 16, 2026 13:10
@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 81.42857% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.16%. Comparing base (972c6ca) to head (b46aa4b).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...mpositions/Navigation/components/Item/Children.tsx 73.91% 6 Missing ⚠️
...ompositions/Navigation/components/Item/Content.tsx 88.46% 3 Missing ⚠️
...s/compositions/Navigation/components/Menu/Menu.tsx 72.72% 3 Missing ⚠️
...mpositions/Navigation/components/Menu/MenuItem.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6216      +/-   ##
==========================================
+ Coverage   92.15%   92.16%   +0.01%     
==========================================
  Files         464      469       +5     
  Lines        9687     9690       +3     
  Branches     3902     3903       +1     
==========================================
+ Hits         8927     8931       +4     
+ Misses        689      688       -1     
  Partials       71       71              
Files with missing lines Coverage Δ
.../compositions/Navigation/components/Item/Badge.tsx 100.00% <100.00%> (ø)
...s/compositions/Navigation/components/Item/Item.tsx 83.09% <100.00%> (ø)
...itions/Navigation/components/Item/ItemExpanded.tsx 82.00% <ø> (ø)
...itions/Navigation/components/Item/ItemProvider.tsx 100.00% <ø> (ø)
...itions/Navigation/components/Item/PinnedButton.tsx 89.28% <ø> (ø)
...ositions/Navigation/components/Menu/NestedMenu.tsx 100.00% <100.00%> (ø)
...compositions/Navigation/components/PinnedItems.tsx 53.33% <ø> (ø)
...i/src/components/compositions/Navigation/index.tsx 100.00% <ø> (ø)
...mpositions/Navigation/components/Menu/MenuItem.tsx 72.72% <0.00%> (ø)
...ompositions/Navigation/components/Item/Content.tsx 88.46% <88.46%> (ø)
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9e4748...b46aa4b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request refactor Refactor without breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants