- 
                Notifications
    
You must be signed in to change notification settings  - Fork 23
 
BB-705: Bump rdkafka to fix DEP0048 util.isError() #2667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development/9.0
Are you sure you want to change the base?
Conversation
          Hello bourgoismickael,My role is to assist you with the merge of this Available options
 Available commands
 Status report is not available.  | 
    
          Codecov Report❌ Patch coverage is  
 ❌ Your patch check has failed because the patch coverage (60.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files
 ... and 3 files with indirect coverage changes 
 @@                 Coverage Diff                 @@
##           development/9.0    #2667      +/-   ##
===================================================
- Coverage            74.28%   74.09%   -0.19%     
===================================================
  Files                  201      201              
  Lines                13444    13447       +3     
===================================================
- Hits                  9987     9964      -23     
- Misses                3447     3473      +26     
  Partials                10       10              
 Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
  | 
    
        
          
                package.json
              
                Outdated
          
        
      | "mongodb": "^6.11.0", | ||
| "node-forge": "^1.3.1", | ||
| "node-rdkafka": "^2.12.0", | ||
| "node-rdkafka": "^3.4.1", | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we test a zenko build with this change early, as this is a major version bump?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The major is only because they don't support old nodejs version.
But right now tests here are not passing so it seems to break something
03eaef7    to
    e910dcc      
    Compare
  
    | 
           For some reason it spams these debug messages: {"name":"BackbeatConsumer","time":1754069124682,"topic":"backbeat-func-test-repstatus",
 "groupId":"backbeat-func-test-group-id","level":"debug",
 "message":"not enough message available yet, retry in 1s: 0",
 "hostname":"pkrvmjbmru5nbw0","pid":8418}
{"name":"BackbeatConsumer","time":1754069124682,"topic":"backbeat-func-test-repstatus",
 "groupId":"backbeat-func-test-group-id","level":"debug",
 "message":"error, retry in 1s: KafkaConsumer is not connected",
 "hostname":"pkrvmjbmru5nbw0","pid":8418} | 
    
This deprecation warning spams stderr logs Fix done in this release: https://github.com/Blizzard/node-rdkafka/releases/tag/v3.3.1 Going from 2.18.0 to 3.6.0 updates librdkafka from 2.3.0 to 2.12.0
e5629fc    to
    a5d2213      
    Compare
  
    
          Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the   | 
    
a5d2213    to
    409b64a      
    Compare
  
    
This deprecation warning spams stderr logs
Fix done in this release: https://github.com/Blizzard/node-rdkafka/releases/tag/v3.3.1
Going from 2.18.0 to 3.4.1 updates librdkafka from 2.3.0 to 2.10.1