Skip to content

Conversation

@BourgoisMickael
Copy link
Contributor

This deprecation warning spams stderr logs

Fix done in this release: https://github.com/Blizzard/node-rdkafka/releases/tag/v3.3.1

Going from 2.18.0 to 3.4.1 updates librdkafka from 2.3.0 to 2.10.1

@bert-e
Copy link
Contributor

bert-e commented Aug 1, 2025

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@codecov
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.09%. Comparing base (b6d9035) to head (a5d2213).

Files with missing lines Patch % Lines
extensions/gc/GarbageCollectorProducer.js 50.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (60.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/BackbeatProducer.js 89.28% <100.00%> (ø)
extensions/gc/GarbageCollectorProducer.js 76.92% <50.00%> (-5.69%) ⬇️

... and 3 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 80.33% <ø> (ø)
Core Library 80.46% <100.00%> (-0.44%) ⬇️
Ingestion 70.28% <ø> (ø)
Lifecycle 78.63% <50.00%> (-0.05%) ⬇️
Oplog Populator 85.06% <ø> (ø)
Replication 58.59% <ø> (ø)
Bucket Scanner 85.76% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/9.0    #2667      +/-   ##
===================================================
- Coverage            74.28%   74.09%   -0.19%     
===================================================
  Files                  201      201              
  Lines                13444    13447       +3     
===================================================
- Hits                  9987     9964      -23     
- Misses                3447     3473      +26     
  Partials                10       10              
Flag Coverage Δ
api:retry 9.46% <20.00%> (-0.01%) ⬇️
api:routes 9.27% <20.00%> (-0.01%) ⬇️
bucket-scanner 85.76% <ø> (ø)
ft_test:queuepopulator 9.95% <20.00%> (-0.26%) ⬇️
ingestion 12.52% <20.00%> (-0.01%) ⬇️
lifecycle 18.67% <20.00%> (-0.02%) ⬇️
replication 18.48% <60.00%> (-0.01%) ⬇️
unit 50.00% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

package.json Outdated
"mongodb": "^6.11.0",
"node-forge": "^1.3.1",
"node-rdkafka": "^2.12.0",
"node-rdkafka": "^3.4.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we test a zenko build with this change early, as this is a major version bump?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The major is only because they don't support old nodejs version.
But right now tests here are not passing so it seems to break something

@BourgoisMickael
Copy link
Contributor Author

For some reason it spams these debug messages:

{"name":"BackbeatConsumer","time":1754069124682,"topic":"backbeat-func-test-repstatus",
 "groupId":"backbeat-func-test-group-id","level":"debug",
 "message":"not enough message available yet, retry in 1s: 0",
 "hostname":"pkrvmjbmru5nbw0","pid":8418}

{"name":"BackbeatConsumer","time":1754069124682,"topic":"backbeat-func-test-repstatus",
 "groupId":"backbeat-func-test-group-id","level":"debug",
 "message":"error, retry in 1s: KafkaConsumer is not connected",
 "hostname":"pkrvmjbmru5nbw0","pid":8418}

This deprecation warning spams stderr logs

Fix done in this release: https://github.com/Blizzard/node-rdkafka/releases/tag/v3.3.1

Going from 2.18.0 to 3.6.0 updates librdkafka from 2.3.0 to 2.12.0
@scality scality deleted a comment from bert-e Oct 31, 2025
@bert-e
Copy link
Contributor

bert-e commented Oct 31, 2025

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@scality scality deleted a comment from bert-e Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants