Skip to content

do not allow using crr location as a locationConstraint #5806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: development/9.1
Choose a base branch
from
Open

do not allow using crr location as a locationConstraint #5806

wants to merge 1 commit into from

Conversation

Kerkesni
Copy link
Contributor

  • Support the 'CRR' type for locations
  • Do not allow setting the CRR location as a locationConstraint

Issue: CLDSRV-653

@bert-e
Copy link
Contributor

bert-e commented May 22, 2025

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented May 22, 2025

Incorrect fix version

The Fix Version/s in issue CLDSRV-653 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.0.12

  • 9.1.0

Please check the Fix Version/s of CLDSRV-653, or the target
branch of this pull request.

@Kerkesni Kerkesni force-pushed the improvement/CLDSRV-653 branch from 171a8ec to f209c2a Compare May 22, 2025 08:29
@codecov Codecov
Copy link

codecov bot commented May 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.62%. Comparing base (dee5d54) to head (f209c2a).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/Config.js 77.19% <ø> (ø)
lib/api/bucketPut.js 94.17% <100.00%> (ø) 
@@               Coverage Diff                @@
##           development/9.0    #5806   +/-   ##
================================================
  Coverage            75.62%   75.62%           
================================================
  Files                  188      188           
  Lines                11948    11948           
================================================
  Hits                  9036     9036           
  Misses                2912     2912
Flag Coverage Δ
ceph-backend-test 46.86% <100.00%> (ø)
file-ft-tests 47.24% <100.00%> (ø)
kmip-ft-tests 26.71% <100.00%> (ø)
mongo-v0-ft-tests 47.68% <100.00%> (ø)
mongo-v1-ft-tests 47.69% <100.00%> (ø)
multiple-backend 35.39% <100.00%> (ø)
quota-tests 32.12% <100.00%> (ø)
quota-tests-inflights 34.13% <100.00%> (+0.03%) ⬆️
unit 65.64% <100.00%> (ø)
utapi-v2-tests 33.21% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Kerkesni Kerkesni changed the base branch from development/9.0 to development/9.1 May 23, 2025 08:20
@bert-e
Copy link
Contributor

bert-e commented May 23, 2025

Incorrect fix version

The Fix Version/s in issue CLDSRV-653 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.1.0

Please check the Fix Version/s of CLDSRV-653, or the target
branch of this pull request.

francoisferrand
francoisferrand reviewed May 26, 2025
View reviewed changes
lib/api/bucketPut.js
@@ -59,7 +59,8 @@ function checkLocationConstraint(request, locationConstraint, log) {
return { error: errorInstances.InvalidLocationConstraint.
customizeDescription(errMsg) };
}
if (locationConstraints[locationConstraintChecked].isCold) {
if (locationConstraints[locationConstraintChecked].isCold ||
locationConstraints[locationConstraintChecked].type === 'crr') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of doing the check based on the type, maybe we could to introduce a feature parameter, like isCold → isCrr ?

@bert-e
Copy link
Contributor

bert-e commented May 26, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

francoisferrand
francoisferrand reviewed May 26, 2025
View reviewed changes
lib/api/bucketPut.js
@@ -59,7 +59,8 @@ function checkLocationConstraint(request, locationConstraint, log) {
return { error: errorInstances.InvalidLocationConstraint.
customizeDescription(errMsg) };
}
if (locationConstraints[locationConstraintChecked].isCold) {
if (locationConstraints[locationConstraintChecked].isCold ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

location constraint can be set on bucket (and should thus be rejected), but can also be specified directly in putObject / copyObject / putMpu : this needs to be handled as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoisferrand francoisferrand francoisferrand left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kerkesni @bert-e @francoisferrand