Skip to content

fix type/solve_equation #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix type/solve_equation #24

wants to merge 1 commit into from

Conversation

@s1270179
Copy link
Contributor

No description provided.

@s1270179 s1270179 added the completed 採点を要求 label Oct 17, 2019
mt-coff
mt-coff reviewed Oct 31, 2019
View reviewed changes
src/type/solve_equation.py
return -1*a//b
a = str(int(a / gcd))
b = str(int(b / gcd))
return ( "-" + b + "/" + a)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

返り値は文字列ではなく数値がほしいです 🙇

mt-coff
mt-coff requested changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@mt-coff mt-coff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ヒントになるかわからないですが
Python Fraction で調べてみてもいいかもしれません

@uzimaru0000 uzimaru0000 added the reject [TA] 修正する箇所ありなので修正してください :bow: label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mt-coff mt-coff mt-coff requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

completed 採点を要求 reject [TA] 修正する箇所ありなので修正してください :bow:

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@s1270179 @mt-coff @uzimaru0000