rt-app: Don't validate cpuset in config#135
Open
cloehle wants to merge 1 commit intoscheduler-tools:masterfrom
Open
rt-app: Don't validate cpuset in config#135cloehle wants to merge 1 commit intoscheduler-tools:masterfrom
cloehle wants to merge 1 commit intoscheduler-tools:masterfrom
Conversation
The existing validation of cpuset based on the maximum CPU having the index sysconf(_SC_NPROCESSORS_CONF) - 1 is flawed. CPUs can be hotplugged out or disabled by nosmt. Hotplugging can even happen simultaneously to rt-app running, making the validation attempt futile. Instead of attempting to validate the config just let it fail whenever sched_setaffinity() is called. Signed-off-by: Christian Loehle <christian.loehle@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing validation of cpuset based on the maximum CPU having the index sysconf(_SC_NPROCESSORS_CONF) - 1 is flawed. CPUs can be hotplugged out or disabled by nosmt.
Hotplugging can even happen simultaneously to rt-app running, making the validation attempt futile.
Instead of attempting to validate the config just let it fail whenever sched_setaffinity() is called.