Open
Conversation
credp
approved these changes
Jul 14, 2017
Contributor
credp
left a comment
There was a problem hiding this comment.
I think it looks good - could be hugely useful.
| pthread_cond_wait(&(rdata->res.barrier.c_obj), &(rdata->res.barrier.m_obj)); | ||
| rdata->res.barrier.waiting += 1; | ||
| { | ||
| struct timespec t_delta; |
Contributor
There was a problem hiding this comment.
This seems a bit nitpicky, so feel free to ignore it, but you could put t_delta inside the if condition to avoid the additional {} indent.
added 2 commits
July 20, 2017 15:17
End-to-end latency of a pipeline of tasks is a useful metric to evaluate synthetic mobile-like workloads (e.g., audio/video decoding pipeline). Add such feature by piggybacking barrier_like events. Signed-off-by: Juri Lelli <juri.lelli@arm.com>
Add information in the tutorial and an example about how bref event can be used to measure end-to-end latency of pipelines of tasks. Signed-off-by: Juri Lelli <juri.lelli@arm.com>
Contributor
|
Hey @jlelli did you get anywhere with this? |
Contributor
Author
|
Hey, I didn't unfortunately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've been thinking it would be helpful to have a metric to measure end-to-end latency of pipelines of tasks (to compare against energy consumption).
The idea is to propose rt-app as a tool for creating mobile like type of workloads during the Scheduler Workloads uconf at LPC (if accepted).
Still highly WIP, I'm sure it doesn't always work reliably, but get some early feedback would be much appreciated.