Render GitHub alert blockquotes - #418
Open
yusufm wants to merge 1 commit into
Open
Conversation
schuyler
requested changes
Jun 22, 2026
Owner
There was a problem hiding this comment.
Thanks for the PR, @yusufm!
Issues
- Nested blockquotes: an alert containing a nested
> >quote makes the regex stop at the inner</blockquote>, leaving a dangling outer tag and malformed HTML. - Single-type test coverage: only
WARNINGis exercised, so a typo in any of theNOTE/TIP/IMPORTANT/CAUTIONclass or title mappings would go uncaught. - Case-insensitivity untested: the case-insensitive flag (which supports
[!note]) has no test guarding it against a silent regression.
Suggestions
- A regression test confirming an alert marker inside a fenced code block stays unconverted would guard against the regex becoming too greedy.
- A multi-paragraph alert body test would document the expected behavior and protect the body-capture logic.
- Gating the transform and its stylesheet behind an
MPRendererDataSourceflag (as other renderer features are) would keep the architecture consistent, though it could also land as a follow-up. - An
NSAssertafter the regex compile would surface a pattern failure during development rather than silently turning the transform into a no-op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #291
Summary
Tests