Skip to content

fix: don't traverse into excluded directories #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Apr 18, 2025

This avoids recursing into excluded directories, which fixes issues with adding "README.md" to your include to find all excluded directories that have a readme are also now included. There's now INFO logging that explains why things are included or excluded.

I think this is just a fix, but we could gate it by minimum-version.

@jcfr
Copy link
Contributor

jcfr commented Apr 18, 2025

It may be worth updating the documentation to describe that excludes are processed first, then includes.

@henryiii henryiii marked this pull request as draft April 18, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants