docs: add summary lines to 9 field/name/parameter operation docstrings#4134
Open
TaiSakuma wants to merge 3 commits into
Open
docs: add summary lines to 9 field/name/parameter operation docstrings#4134TaiSakuma wants to merge 3 commits into
TaiSakuma wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
|
Member
Author
|
Follow-up per @ikrommyd's review on #4130: the Returns
|
Add a Google-style one-line summary and `Returns:`/`Examples:` section headers to the 9 field/name/parameter operations in `src/awkward/operations/`: with_field, without_field, with_name, with_parameter, without_parameters, with_named_axis, without_named_axis, fields, parameters. Follows the pilot in scikit-hep#3946 on `ak.flatten`. Original body text is preserved; only structural edits are applied. Refs scikit-hep#3980. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
…#3980. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…tion. Refs scikit-hep#3980. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
97d116f to
6c4b5c3
Compare
|
The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR4134 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rolls the pilot from #3946 out to the 9 operations in the Field / name / parameter ops batch of #3980:
with_field,without_field,with_name,with_parameter,without_parameters,with_named_axis,without_named_axis,fields,parameters.Each docstring now has:
""".Returns:andExamples:section headers (the latter only where examples exist).Original body text is preserved; only structural edits are applied. The summary lines were reviewed against the checklist posted in #3980.
Summary lines
ak.with_fieldak.without_fieldak.with_name__record__parameter set to the given name.ak.with_parameterak.without_parametersak.with_named_axisak.without_named_axisak.fieldsak.parametersNotes for reviewers
ak.with_named_axis's narrative reads "…with a new name." — a copy-paste fromak_with_name.py. The function attaches named axes; the new summary says so. Happy to fix the body here or in a follow-up if you prefer.ak.with_field's "a new field added, or an existing field replaced" reflects the explicit replace-if-exists branch in_impl.ak.with_namekeeps__record__in backticks — it is the literal parameter key being set (the checklist's meaning-bearing exception).ak.without_parameters("from every layout node") vsak.with_parameter("on the outermost layout node") is a real asymmetry in the implementations, not a mirroring defect.Test plan
Args:blocks and doctests byte-identical; no original narrative text lost.Part of #3980. Draft for initial review; will mark ready once CI passes and the preview is checked.
AI assistance disclosure
Drafted with Claude Code: summaries drafted by Claude Sonnet 4.6, adversarially verified against the implementations by independent Claude Opus 4.8 agents, mechanically validated (docstring-only changes, original text preserved), and reviewed by a human before submission.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com