- 
                Notifications
    You must be signed in to change notification settings 
- Fork 22
feat: optimize the parsing code for speed #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 🏎️ Benchmark Comparison | 
| Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
- Coverage   97.43%   97.18%   -0.25%     
==========================================
  Files           2        2              
  Lines         506      462      -44     
  Branches       57       56       -1     
==========================================
- Hits          493      449      -44     
  Misses          8        8              
  Partials        5        5              
 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
9898908    to
    cb6fc5b      
    Compare
  
    14ad445    to
    46cbe78      
    Compare
  
    460fd14    to
    dc9ccdc      
    Compare
  
    2e4555f    to
    d0fc700      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR simplifies integer parsing and improves memory management in the LHE file parser. The changes remove unnecessary float conversion when parsing integer values and optimize XML element memory cleanup.
- Simplified integer parsing by removing redundant int(float(...))conversions
- Improved memory management with periodic root element clearing and cleanup in finally block
- Refactored string processing to pre-strip particle strings for consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| No speed up, cf. #300 (comment) | 
No description provided.