Skip to content

Conversation

@APN-Pucky
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

🏎️ Benchmark Comparison


------------------------------------------------------------------------------------------ benchmark: 2 tests -----------------------------------------------------------------------------------------
Name (time in s)                                Min               Max              Mean            StdDev            Median               IQR            Outliers     OPS            Rounds  Iterations
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_fromfile_and_to_awkward (0001_base)     3.8559 (1.0)      3.8981 (1.0)      3.8702 (1.0)      0.0118 (1.0)      3.8686 (1.0)      0.0044 (1.0)           3;3  0.2584 (1.0)          10           1
test_fromfile_and_to_awkward (0002_mr)       3.8860 (1.01)     3.9196 (1.01)     3.8990 (1.01)     0.0126 (1.07)     3.8944 (1.01)     0.0229 (5.15)          3;0  0.2565 (0.99)         10           1
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.18%. Comparing base (cdc987b) to head (753e01b).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/pylhe/__init__.py 97.22% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
- Coverage   97.43%   97.18%   -0.25%     
==========================================
  Files           2        2              
  Lines         506      462      -44     
  Branches       57       56       -1     
==========================================
- Hits          493      449      -44     
  Misses          8        8              
  Partials        5        5              
Flag Coverage Δ
unittests-3.10 ?
unittests-3.11 ?
unittests-3.12 ?
unittests-3.13 ?
unittests-3.9 97.18% <97.22%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@APN-Pucky APN-Pucky changed the base branch from ci_benchmark to ak_typing October 30, 2025 12:35
@APN-Pucky APN-Pucky changed the base branch from ak_typing to ci_benchmark October 30, 2025 12:36
@APN-Pucky APN-Pucky force-pushed the code_optimization branch 2 times, most recently from 9898908 to cb6fc5b Compare October 30, 2025 13:05
Base automatically changed from ci_benchmark to main October 30, 2025 15:59
@APN-Pucky APN-Pucky requested a review from Copilot October 30, 2025 17:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies integer parsing and improves memory management in the LHE file parser. The changes remove unnecessary float conversion when parsing integer values and optimize XML element memory cleanup.

  • Simplified integer parsing by removing redundant int(float(...)) conversions
  • Improved memory management with periodic root element clearing and cleanup in finally block
  • Refactored string processing to pre-strip particle strings for consistency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@APN-Pucky
Copy link
Member Author

No speed up, cf. #300 (comment)

@APN-Pucky APN-Pucky closed this Oct 30, 2025
@eduardo-rodrigues eduardo-rodrigues deleted the code_optimization branch October 30, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants