Skip to content

Replaced VERSION_PLACEHOLDER with 0.3 for poetry compatibility#125

Open
matteobolner wants to merge 1 commit into
scikit-learn-contrib:masterfrom
matteobolner:master
Open

Replaced VERSION_PLACEHOLDER with 0.3 for poetry compatibility#125
matteobolner wants to merge 1 commit into
scikit-learn-contrib:masterfrom
matteobolner:master

Conversation

@matteobolner
Copy link
Copy Markdown

Poetry can't install the package without an explicit version. Hopefully this can be of help to someone else
Cheers,
Matteo

@solegalli
Copy link
Copy Markdown
Collaborator

Hi @matteobolner

I'm helping @danielhomola maintain the library. Sorry for the delayed response.

We need the setup to specify a dinamic vesion. We can't hard code the version as per your suggestion.

Would something like this work with poetry?
https://github.com/feature-engine/feature_engine/blob/1fc4a439a603e7b0fb9b83aa346896daab65167e/setup.py#L24-L33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants