BUG: Fix divide-by-zero and over-generation in KMeansSMOTE - #1189
Open
saitejabandaru-in wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1186
KMeansSMOTEhas two numerical issues that cause it to crash or generate the wrong number of samples:_find_cluster_sparsity), it divides bynon_diag_elements. IfXcontains only one sample (or identically 1 valid point),non_diag_elementsis 0, causing a divide-by-zero error.cluster_n_samples, it usesmath.ceil(). If there are many valid clusters, taking the ceiling of every fractional sample count guarantees that the sum of generated samples will significantly exceed the requestedn_samples.Fix
if non_diag_elements == 0: return 0.0in_find_cluster_sparsity.math.ceiltoroundforcluster_n_samplesto minimize overshoot. (Any exact sample distribution can be further refined, butroundis standard for integer weighting).