Merged
Conversation
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Member
frenzymadness
left a comment
frenzymadness
left a comment
There was a problem hiding this comment.
I did a fast review and found only one real problem and some possible improvements.
Fix README.md file. Add more desciption to functions and return boolean in function that are valid for returning more functions Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
phracek
force-pushed
the
fix_logging_reamd
branch
from
ea99f84 to
1787800
Compare
in case it is boolean Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
phracek
force-pushed
the
fix_logging_reamd
branch
from
1787800 to
bc394fd
Compare
Member
frenzymadness
left a comment
frenzymadness
left a comment
There was a problem hiding this comment.
I've found one typo and some possible improvements in typing.
Co-authored-by: Lumír 'Frenzy' Balhar <frenzy.madness@gmail.com>
Co-authored-by: Lumír 'Frenzy' Balhar <frenzy.madness@gmail.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.