Skip to content

Conversation

@chrfranke
Copy link
Contributor

This is a retry of #1425.

Uses a different approach to let menu-complete only append a space if all alternatives allow this.

Copy link
Collaborator

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant "Request changes".

@scop
Copy link
Owner

scop commented Oct 26, 2025

Just a note, I plan to release the next bash-completion version really soon, as soon as tomorrow (Oct 27). Would be nice to get this included in that release if we can get it merged in time (can also wait for a couple of more days if that's what it takes, but would rather not).

@chrfranke
Copy link
Contributor Author

Thanks for the info, will push a new version today.

@chrfranke
Copy link
Contributor Author

Done. Now always use _comp_compgen -P for prefixes, IMO easier to read.

Copy link
Collaborator

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM basically.

@scop scop merged commit 31675a3 into scop:main Oct 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants