test(scp): create files on the fly to work around Windoes filesystem #1491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2025
akinomyoga
force-pushed
the
_comp_dequote_incomplete-2
branch
from
8c6ace9 to
f37e2ac
Compare
scop
approved these changes
Oct 31, 2025
Owner
scop
left a comment
scop
left a comment
There was a problem hiding this comment.
No problem, this is an easy thing to miss and we should have had checks for it way earlier already. Thanks for addressing it quickly!
Collaborator
Author
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue pointed out in #1485 (comment). I'm sorry that I caused this again. I caused the same issue before in #1397 (comment), which was fixed in #1408. I realized that the previous issue was pointed out this June, but #1357 (i.e., the original PR of #1485) was created this April. I created the original change before the previous issue but failed to properly update the changes.
In this PR, I removed the affected files and used the same approach to the test as #1408.
Fixes #1490.