Skip to content

Conversation

@adzhindzhi
Copy link
Contributor

@adzhindzhi adzhindzhi commented Nov 28, 2025

Resolves:

UEPR-426

Changes:

  • Update the Location Tou step to also gather Birth Data
  • Handle missing country info correctly

…andle missing country field in the user data
@mxmou
Copy link
Contributor

mxmou commented Nov 30, 2025

Not related to this PR specifically, but I've noticed that on the Terms of Use branch, the background color of the splash page and other pages is slightly different (#ffffff instead of #fcfcfc) because of this code. Is that intended?

It look like this on develop:
scratch_background_fcfcfc

And on release/terms-of-use:
scratch_background_ffffff

// Even though we just started gathering the state and existing users will not have it
// There is a possibility in which the user updated the state through the account settings,
// but the birth year/month is missing from the info. In that case, we would only want to display the
// birth date section
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point :)

@KManolov3
Copy link
Contributor

@mxmou That's a good catch! I don't think this was intended.

@adzhindzhi adzhindzhi merged commit 62b6307 into scratchfoundation:release/terms-of-use Dec 3, 2025
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants