feat: unify cpu / gpu provers under same framework #923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 21, 2025
## Motivation
We want to unify the prover's workflow for opcode circuits and table
circuits. As they follow the same kind of workflow, i.e.
1. infer tower witness;
2. run tower prover;
3. run main sumcheck which is optional for table circuits.
Before this pr, the **opcode** circuit includes multiple
read/write/logup records in a **single** tower while **table** circuit
packs read/write/logup records into one dedicated tower for each
read/write/logup expression. We found that the way that's used by table
circuit to build tower tree is better than that of opcode.
## Performance
| benchmark | proof size (MB) | proving time |
|------------|-----------------|-------------|
| fibonacci 2^20 | 1.14 -> 1.2 (5%) | -0.8% |
| fibonacci 2^21 | 1.22 -> 1.28 (5%) | -5% |
| fibonacci 2^22 | 1.3 -> 1.37 (5%) | -10%|
**New issue**: The proof size increase is due to we have more `ProdSpec`
and `LogupSpec` which implies more points and evaluations in the `struct
TowerProof`. Note that after we abandon the old "interleaving" method,
the number of rounds per product spec and lougup spec are same now,
therefore, we can remove this new overhead in follow up pr.
## Impact
Blocker for #923.
---------
Co-authored-by: sm.wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.