Skip to content

fix: dev genesis hash #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2025
Merged

fix: dev genesis hash #196

merged 5 commits into from
Apr 23, 2025

Conversation

frisitano
Copy link
Collaborator

Overview

This PR makes changes that allow for a scroll dev chain to be run. This is achieved via the following three modifications:

  • Populate L1 fee contract storage slots used for L1 fee calculation in the dev genesis.
  • Do not use the static DEV_GENESIS_HASH in the ScrollChainSpec and instead use new_unhashed when instantiating the header.
  • Set the base fee to a static 100; previously it was defaulting to 0, which was resulting in an error downstream. A production solution will be provided in Implement the geth's CalcBaseFee formula  #210 but the current "hack" will unblock sequencer dependent workstreams.

@frisitano frisitano requested a review from greged93 April 22, 2025 07:55
Copy link

codspeed-hq bot commented Apr 22, 2025

CodSpeed Performance Report

Merging #196 will not alter performance

Comparing fix/dev-genesis-hash (c31fc47) with scroll (07059ec)

Summary

✅ 77 untouched benchmarks

@frisitano frisitano changed the title Fix: dev genesis hash fix: dev genesis hash Apr 22, 2025
Copy link
Collaborator

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@frisitano frisitano merged commit ced67f4 into scroll Apr 23, 2025
46 checks passed
@frisitano frisitano deleted the fix/dev-genesis-hash branch April 23, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants