feat: require top-level call to commitAndFinalizeBatch#120
Merged
Conversation
zimpha
approved these changes
Jun 17, 2025
zimpha
pushed a commit
that referenced
this pull request
Jun 25, 2025
Thegaram
added a commit
that referenced
this pull request
Jun 26, 2025
alexanvl
pushed a commit
to DogeOS69/scroll-contracts
that referenced
this pull request
Jul 31, 2025
* hotfix: forbid enforced gateway (scroll-tech#101) Co-authored-by: Péter Garamvölgyi <peter@scroll.io> * chore: bump version 2.0.1 (scroll-tech#102) * ci: bump GitHub Action versions (scroll-tech#107) * ci: add Slither static-analysis (scroll-tech#103) Co-authored-by: Péter Garamvölgyi <peter@scroll.io> * new `ScrollChainCommitmentVerifier` (scroll-tech#95) Co-authored-by: Péter Garamvölgyi <peter@scroll.io> * build(deps): bump base-x from 3.0.9 to 3.0.11 (scroll-tech#108) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add L2SystemContract (scroll-tech#114) * feat: add e2e devnet deployment scripts (scroll-tech#97) * feat: add pause controller (scroll-tech#117) * feat: consider EIP-7623 floor gas in message queue (scroll-tech#118) * feat: add L1SystemConfig events (scroll-tech#119) * feat: require top-level call to commitAndFinalizeBatch (scroll-tech#120) * feat: add new zkevm verifier for Feynman upgrade (scroll-tech#123) * feat(feynman): update L1GasPriceOracle (scroll-tech#124) * remove unused contracts and functions (scroll-tech#110) Co-authored-by: Péter Garamvölgyi <peter@scroll.io> * fix: allow only top level call in commitAndFinalizeBatch (scroll-tech#126) * feat: support resetPauseCooldownPeriod (scroll-tech#127) * fix conflicts part 1 fix conflicts part2 fix conflict part3 fix compile part1 fix compile part2 fix compile part3 register V8 verifier: feynman upgrade todo revert this after test fix rollup-config missing endpoint remove debug log add -vvvv set batch size to 10 some fix fix read private key use a small batch size 5, so the l2-sequencer won't get stuck * fix: read from file still required while run gen-configs * improve verify.sh * use deterministic foundry version v1.3.0-rc2 * fix rollup-config.json gas_price_oracle_contract_address * remove --resume * set BATCH_SIZE=7 * fix bug: missing L2_SYSTEM_CONFIG other missing fields in genesis.json * set genesisStateRoot default to null set missingHeaderFieldsSHA256 default to null //TODO * replace scrolltech with dogeos69 * verify.sh add L2SystemConfig --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Xi Lin <zimpha@gmail.com> Co-authored-by: Péter Garamvölgyi <peter@scroll.io> Co-authored-by: Souhail M. <65525816+mssassii@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Morty <70688412+yiweichi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our L1 consolidation relies on decoding transaction calldata. If calls to
commitAndFinalizeBatchare done via a smart contract account, for example, then this decoding will fail. It is easier to disallow it than to implement internal transaction fetching and decoding in the indexers.Technically, this is also a requirement for
commitBatchesandfinalizeBundlePostEuclidV2. But the risk is bigger for permissionless submission (commitAndFinalizeBatch).