-
Notifications
You must be signed in to change notification settings - Fork 0
Update README.md #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update README.md #15
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -74,6 +74,8 @@ docker run -d -p 5000:5000 vampi_docker:latest | |
docker-compose up -d | ||
~~~~ | ||
|
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should include instructions for running integration tests, API endpoint tests, and expected test coverage metrics (e.g., minimum coverage percentage required for PRs to be accepted). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add documentation about runtime status monitoring and health check endpoints to ensure proper application monitoring in production. |
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing testing instructions and test coverage requirements. Should include information about running tests and expected coverage thresholds. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider adding health check endpoint documentation and status monitoring information for production deployments. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Include a section about performance metrics collection and monitoring strategy for production deployments. |
||
## Customizing token timeout and vulnerable environment or not | ||
If you would like to alter the timeout of the token created after login or if you want to change the environment **not** to be vulnerable then you can use a few ways depending how you run the application. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding error handling information and potential issues one might face while running the application in the README. Current documentation lacks details on troubleshooting and error cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please provide an example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's an example of error handling and troubleshooting section that could be added to the README:
Solution:
sudo lsof -i :5000
to find the PID, thenkill -9 <PID>
If the container exits immediately after starting:
docker logs vampi_docker
Application-Specific Issues
Token Authentication Errors
Database Connection Issues
Solution:
Environment Configuration
Getting Help
If you encounter any other issues:
docker logs vampi_docker