Skip to content

Update main.yml workflow to run integration suite on many scylla versions #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 24, 2025
Merged

Update main.yml workflow to run integration suite on many scylla versions #574

merged 4 commits into from
Oct 24, 2025

Conversation

@dkropachev
Copy link
Collaborator

@dkropachev dkropachev commented Sep 22, 2025 •
edited
Loading

Does the following:

  1. Calculates scylla and cassandra version dynamically
  2. Add integration tests with following scylla versions: 2025.1 (LTS-LATEST), 2024.1 (LTS-PRIOR), 2025.3 (LATEST) and 2025.3 (PRIOR).
  3. Add integration tests with following cassandra versions: 5.x and 4.x
  4. Adds cache for ccm images, pip and java sdk
  5. Fixes tests to match new cassandra behavior.

@dkropachev dkropachev force-pushed the dk/cicd-run-integration-tests-against-scyllas branch 3 times, most recently from be25366 to 0ffde82 Compare September 22, 2025 17:05
@Lorak-mmk
Copy link

What is the point of testing multiple versions in drivers CI when we have matrix?

@dkropachev
Copy link
Collaborator Author

What is the point of testing multiple versions in drivers CI when we have matrix?

You can run matrix tests only after driver is released.
Well technically we can run them against master, but we don't do that by good reason.

Matrix tests are there not to check drivers, but to check server.
We shall not confuse them with driver tests.

@dkropachev
Copy link
Collaborator Author

Test are failing bacause of the broken test: #575

@dkropachev dkropachev changed the title Update main.yml workflow to run integration suit on many scylla versions Update main.yml workflow to run integration suite on many scylla versions Sep 23, 2025
@sylwiaszunejko
Copy link
Collaborator

Test are failing bacause of the broken test: #575

@dkropachev As this issue is fixed, you can try to rebase add see if there are any issues with the CI

nikagra
nikagra reviewed Oct 21, 2025
View reviewed changes
@dkropachev dkropachev force-pushed the dk/cicd-run-integration-tests-against-scyllas branch 4 times, most recently from 773ba14 to a490188 Compare October 23, 2025 12:26
@dkropachev
Copy link
Collaborator Author

LTS-PRIOR fails due to some weird problem, I have created a separate issue to investiage it, for now let's keep this scylla version in, and live for some time with broken pipeline.

@dkropachev dkropachev self-assigned this Oct 23, 2025
@dkropachev dkropachev force-pushed the dk/cicd-run-integration-tests-against-scyllas branch from a490188 to b0fda08 Compare October 23, 2025 17:24
nikagra
nikagra reviewed Oct 23, 2025
View reviewed changes
Makefile
fi
rm -rf /tmp/download.ccm || true
mkdir /tmp/download.ccm || true
ccm create ccm_1 -i 127.0.254. -n 1:0 -v "$${CASSANDRA_VERSION_RESOLVED}" --config-dir=/tmp/download.ccm
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain what is happening in this task, please

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes ccm download an image by creating a cluster of one node, but not starting it

Copy link

@nikagra nikagra Oct 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't CCM do it by itself when specific version requested by a test/CCM bridge?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly

@dkropachev
cicd: update main.yml workflow to run integration suit on different b…
c760cd2 
…ackends

Scylla supports 2 last LTS and two last versions.
So, currently it is 2025.1 (LTS_LATEST), 2024.1 (LTS_PRIOR), 2025.3 (LATEST) and 2025.3 (PRIOR).

And add cassandra 4.x and 5.x
@dkropachev
tests: pick correct TLS port for cassandra
76671dd 
Cassandra hosts TLS and non-TLS connections on the same port.
So we need to target driver to 9042 for TLS tests on cassandra.
@dkropachev
tests: ignore TestCloudConnection on non-scylla backend
6c680a3 
It supports only Scylla, so skip it for non-scylla backend.
@dkropachev
tests: replace DATEOF with toTimestamp on cassandra >=4.1
7360c41 
Cassandra after 4.1 dropped DATEOF in favor of toTimestamp.
Test needs to be adopted.
@dkropachev dkropachev force-pushed the dk/cicd-run-integration-tests-against-scyllas branch from b0fda08 to 7360c41 Compare October 23, 2025 20:17
@dkropachev dkropachev merged commit a119ec6 into scylladb:master Oct 24, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lorak-mmk Lorak-mmk Lorak-mmk left review comments

@nikagra nikagra nikagra approved these changes

@sylwiaszunejko sylwiaszunejko sylwiaszunejko approved these changes

Assignees

@dkropachev dkropachev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dkropachev @Lorak-mmk @sylwiaszunejko @nikagra