Benchmark deserialization #198
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stapox35
force-pushed
the
benchmark-serialize
branch
from
f0ba260 to
6a93dfb
Compare
Stapox35
force-pushed
the
benchmark-serialize
branch
from
540f93e to
03f999f
Compare
ZuzaOsa
previously approved these changes
May 6, 2025
Stapox35
force-pushed
the
benchmark-serialize
branch
from
ee940a2 to
6b118d8
Compare
Stapox35
force-pushed
the
benchmark-serialize
branch
from
0df8858 to
39998cc
Compare
|
@Stapox35 If you already have charts drawn using code from this PR, please upload them here in a comment. |
adespawn
requested changes
May 7, 2025
wprzytula
requested changes
May 8, 2025
benchmark/logic/ser.js
Outdated
| function createKeyspace(next) { | ||
| // Keep replication one to reduce time spent in the database | ||
| const query = | ||
| "CREATE KEYSPACE IF NOT EXISTS benchmarks WITH replication = {'class': 'NetworkTopologyStrategy', 'replication_factor': '1' }"; |
There was a problem hiding this comment.
🌱 We should compare results with tablets turned on and off.
Stapox35
force-pushed
the
benchmark-serialize
branch
3 times, most recently
from
3e309f1 to
268b8d0
Compare
adespawn
reviewed
May 14, 2025
wprzytula
reviewed
May 14, 2025
| use std::sync::Arc; | ||
| use uuid::Uuid; | ||
|
|
||
| const CONCURRENCY: usize = 2000; |
There was a problem hiding this comment.
❓ 🤔 Here I can see CONCURRENCY hard-coded. I don't see an equivalent constant in JS benchark code. Where is it?
Comment on lines
+89
to
+126
| let mut handles = vec![]; | ||
| let session = Arc::new(session); | ||
|
|
||
| for i in 0..CONCURRENCY { | ||
| let session_clone = Arc::clone(&session); | ||
| let insert_query_clone = insert_query.clone(); | ||
| handles.push(tokio::spawn(async move { | ||
| insert_data(session_clone, i, n, &insert_query_clone) | ||
| .await | ||
| .unwrap(); | ||
| })); | ||
| } | ||
|
|
||
| let results = join_all(handles).await; | ||
|
|
||
| for result in results { | ||
| result.unwrap(); | ||
| } | ||
|
|
||
| let select_query = session.prepare("SELECT * FROM benchmarks.basic").await?; | ||
|
|
||
| let mut handles = vec![]; | ||
|
|
||
| for i in 0..CONCURRENCY { | ||
| let session_clone = Arc::clone(&session); | ||
| let select_query_clone = select_query.clone(); | ||
| handles.push(tokio::spawn(async move { | ||
| select_data(session_clone, i, n, &select_query_clone) | ||
| .await | ||
| .unwrap(); | ||
| })); | ||
| } | ||
|
|
||
| let results = join_all(handles).await; | ||
|
|
||
| for result in results { | ||
| result.unwrap(); | ||
| } |
There was a problem hiding this comment.
🔧 The logic is duplicated. Please extract the common part to a higher-order function that will accept a closure/Future performing the action. Hint: I'd make the function accept impl Future<Item = Vec<Result<QueryResult, ExecutionError>>>.
adespawn
force-pushed
the
benchmark-serialize
branch
from
044b350 to
b9c72a6
Compare
adespawn
force-pushed
the
benchmark-serialize
branch
from
b9c72a6 to
edf2fc7
Compare
adespawn
previously approved these changes
May 26, 2025
adespawn
force-pushed
the
second-iteration
branch
from
2c4d441 to
e5c09c8
Compare
adespawn
force-pushed
the
second-iteration
branch
from
16128e9 to
6300c7f
Compare
adespawn
dismissed stale reviews from ZuzaOsa and themself
The base branch was changed.
|
I'd really like to see this merged. Can we get this mergeable soon? |
uuid, int, timeuuid, inet, date, time
uuid, int, timeuuid, inet, date, time
Stapox35
force-pushed
the
benchmark-serialize
branch
from
edf2fc7 to
80200da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 4 new benchmarks:
This benchmark uses
executeConcurrentendpoint to insertnrows containinguuid,int,timeuuid,inet,date,timeinto the database. Afterwards it usesexecuteConcurrentendpoint to select all (n) of the inserted rows from the databasentimes.JS:
Rust:
This benchmark executes
nclient.executequeries, that insert a single row containinguuid,int,timeuuid,inet,date,timewaiting for the result of the previous query before executing the next one. Afterwards it executesnclient.executequeries, that select all (n) of the inserted rows, waiting for the result of the previous query before executing the next one.JS:
Rust:
This benchmark uses
executeConcurrentendpoint to insertn*nrows containinguuid,int,timeuuid,inet,date,timeinto the database.JS:
Rust:
This benchmark executes
n*nclient.executequeries, that insert a single row containinguuid,int,timeuuid,inet,date,timewaiting for the result of the previous query before executing the next one.JS:
Rust: