Skip to content

Deprecate exposeOptions in ScyllaDBMonitoring #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 30, 2025
Merged

Deprecate exposeOptions in ScyllaDBMonitoring #3014

merged 4 commits into from
Oct 30, 2025

Conversation

@czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Oct 22, 2025

Description of your changes: Deprecates exposeOptions in Grafana and Prometheus components of ScyllaDBMonitoring.

Which issue is resolved by this Pull Request:
Resolves #3001.

@czeslavo czeslavo added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Oct 22, 2025
@scylla-operator-bot
Copy link
Contributor

scylla-operator-bot bot commented Oct 22, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 22, 2025
@czeslavo czeslavo marked this pull request as ready for review October 22, 2025 18:22
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2025
@czeslavo czeslavo force-pushed the deprecate-scylladbmonitoring-exposeoptions branch from 71caf8f to d417644 Compare October 23, 2025 07:41
@czeslavo czeslavo requested a review from mflendrich October 23, 2025 09:01
@czeslavo
Copy link
Contributor Author

czeslavo commented Oct 24, 2025

/test olm-bundle-openshift-preflight

@czeslavo
Copy link
Contributor Author

czeslavo commented Oct 24, 2025

/test images
/test olm-bundle-openshift-preflight

@czeslavo
Copy link
Contributor Author

czeslavo commented Oct 24, 2025

/test olm-catalog

@czeslavo
Copy link
Contributor Author

czeslavo commented Oct 24, 2025

/test olm-bundle
/test olm-bundle-openshift-preflight

@czeslavo
Copy link
Contributor Author

czeslavo commented Oct 24, 2025

/test olm-bundle-openshift-preflight

@scylla-operator-bot scylla-operator-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2025
@czeslavo czeslavo force-pushed the deprecate-scylladbmonitoring-exposeoptions branch from d417644 to ea92b22 Compare October 28, 2025 12:23
@scylla-operator-bot scylla-operator-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2025
@czeslavo czeslavo mentioned this pull request Oct 28, 2025
Merged
@czeslavo
Copy link
Contributor Author

czeslavo commented Oct 28, 2025

/test e2e-gke-parallel

rzetelskik
rzetelskik reviewed Oct 28, 2025
View reviewed changes
@czeslavo czeslavo force-pushed the deprecate-scylladbmonitoring-exposeoptions branch from ea92b22 to 88cc9de Compare October 29, 2025 15:19
@czeslavo czeslavo requested a review from rzetelskik October 29, 2025 15:22
@czeslavo czeslavo force-pushed the deprecate-scylladbmonitoring-exposeoptions branch from 9131e11 to 88cc9de Compare October 29, 2025 17:23
@scylla-operator-bot
Copy link
Contributor

scylla-operator-bot bot commented Oct 29, 2025

@czeslavo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-multi-datacenter-parallel 88cc9de link false /test e2e-gke-multi-datacenter-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

rzetelskik
rzetelskik approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks!

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2025
@scylla-operator-bot
Copy link
Contributor

scylla-operator-bot bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czeslavo, rzetelskik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2025
@scylla-operator-bot scylla-operator-bot bot merged commit 06e6591 into scylladb:master Oct 30, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rzetelskik rzetelskik rzetelskik approved these changes

@mflendrich mflendrich Awaiting requested review from mflendrich

Assignees

@rzetelskik rzetelskik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate exposeOptions in ScyllaDBMonitoring components

2 participants

@czeslavo @rzetelskik